mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lee Jones <lee@kernel.org>,
	 Daniel Thompson <daniel.thompson@linaro.org>,
	 Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 5/7] backlight: lm3630a_bl: Handle deferred probe
Date: Mon, 04 Mar 2024 11:11:42 +0100	[thread overview]
Message-ID: <20240304-backlight-probe-v1-5-e5f57d0df6e6@linaro.org> (raw)
In-Reply-To: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org>

Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/video/backlight/lm3630a_bl.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index a3412c936ca2..93fd6dbccc28 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -563,10 +563,9 @@ static int lm3630a_probe(struct i2c_client *client)
 	/* pwm */
 	if (pdata->pwm_ctrl != LM3630A_PWM_DISABLE) {
 		pchip->pwmd = devm_pwm_get(pchip->dev, "lm3630a-pwm");
-		if (IS_ERR(pchip->pwmd)) {
-			dev_err(&client->dev, "fail : get pwm device\n");
-			return PTR_ERR(pchip->pwmd);
-		}
+		if (IS_ERR(pchip->pwmd))
+			return dev_err_probe(&client->dev, PTR_ERR(pchip->pwmd),
+					     "fail : get pwm device\n");
 
 		pwm_init_state(pchip->pwmd, &pchip->pwmd_state);
 	}

-- 
2.34.1


  parent reply	other threads:[~2024-03-04 10:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe() Krzysztof Kozlowski
2024-03-04 10:40   ` Daniel Thompson
2024-03-05  8:09     ` Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 2/7] backlight: l4f00242t03: " Krzysztof Kozlowski
2024-03-04 10:40   ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 3/7] backlight: bd6107: Handle deferred probe Krzysztof Kozlowski
2024-03-04 10:41   ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 4/7] backlight: as3711_bl: " Krzysztof Kozlowski
2024-03-04 10:42   ` Daniel Thompson
2024-03-04 10:11 ` Krzysztof Kozlowski [this message]
2024-03-04 10:44   ` [PATCH 5/7] backlight: lm3630a_bl: " Daniel Thompson
2024-03-04 10:11 ` [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Krzysztof Kozlowski
2024-03-04 10:46   ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message Krzysztof Kozlowski
2024-03-04 11:08   ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240304-backlight-probe-v1-5-e5f57d0df6e6@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=daniel.thompson@linaro.org \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®