[PATCH v1 0/3] watchdog: intel-mid_wdt: header and code cleanups

[PATCH v1 0/3] watchdog: intel-mid_wdt: header and code cleanups

[Andy Shevchenko]

A few cleanups against the driver, mostly making an order in the header
inclusions.

Andy Shevchenko (3):
  watchdog: intel-mid_wdt: Remove unused intel-mid.h
  watchdog: intel-mid_wdt: Don't use "proxy" headers
  watchdog: intel-mid_wdt: Get platform data via dev_get_platdata()

 drivers/watchdog/intel-mid_wdt.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

-- 
2.43.0.rc1.1.gbec44491f096

[PATCH v1 1/3] watchdog: intel-mid_wdt: Remove unused intel-mid.h

[Andy Shevchenko]

intel-mid.h is providing some core parts of the South Complex PM,
which are usually are not used by individual drivers. In particular,
this driver doesn't use it, so simply remove the unused header.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/watchdog/intel-mid_wdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
index fb7fae750181..b41c45582aa4 100644
--- a/drivers/watchdog/intel-mid_wdt.c
+++ b/drivers/watchdog/intel-mid_wdt.c
@@ -17,7 +17,6 @@
 #include <linux/platform_data/intel-mid_wdt.h>
 
 #include <asm/intel_scu_ipc.h>
-#include <asm/intel-mid.h>
 
 #define IPC_WATCHDOG 0xf8
 
-- 
2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 1/3] watchdog: intel-mid_wdt: Remove unused intel-mid.h

[Guenter Roeck]

On Tue, Mar 05, 2024 at 06:52:18PM +0200, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/intel-mid_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index fb7fae750181..b41c45582aa4 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -17,7 +17,6 @@
>  #include <linux/platform_data/intel-mid_wdt.h>
>  
>  #include <asm/intel_scu_ipc.h>
> -#include <asm/intel-mid.h>
>  
>  #define IPC_WATCHDOG 0xf8
>  
> -- 
> 2.43.0.rc1.1.gbec44491f096
> 

[PATCH v1 2/3] watchdog: intel-mid_wdt: Don't use "proxy" headers

[Andy Shevchenko]

Update header inclusions to follow IWYU (Include What You Use)
principle.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/watchdog/intel-mid_wdt.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
index b41c45582aa4..06d5d207a065 100644
--- a/drivers/watchdog/intel-mid_wdt.c
+++ b/drivers/watchdog/intel-mid_wdt.c
@@ -9,11 +9,17 @@
  *      Contact: David Cohen <david.a.cohen@linux.intel.com>
  */
 
+#include <linux/bitops.h>
+#include <linux/device.h>
+#include <linux/errno.h>
 #include <linux/interrupt.h>
+#include <linux/math.h>
 #include <linux/module.h>
-#include <linux/nmi.h>
+#include <linux/panic.h>
 #include <linux/platform_device.h>
+#include <linux/types.h>
 #include <linux/watchdog.h>
+
 #include <linux/platform_data/intel-mid_wdt.h>
 
 #include <asm/intel_scu_ipc.h>
-- 
2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 2/3] watchdog: intel-mid_wdt: Don't use "proxy" headers

[Guenter Roeck]

On Tue, Mar 05, 2024 at 06:52:19PM +0200, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/intel-mid_wdt.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index b41c45582aa4..06d5d207a065 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -9,11 +9,17 @@
>   *      Contact: David Cohen <david.a.cohen@linux.intel.com>
>   */
>  
> +#include <linux/bitops.h>
> +#include <linux/device.h>
> +#include <linux/errno.h>
>  #include <linux/interrupt.h>
> +#include <linux/math.h>
>  #include <linux/module.h>
> -#include <linux/nmi.h>
> +#include <linux/panic.h>
>  #include <linux/platform_device.h>
> +#include <linux/types.h>
>  #include <linux/watchdog.h>
> +
>  #include <linux/platform_data/intel-mid_wdt.h>
>  
>  #include <asm/intel_scu_ipc.h>
> -- 
> 2.43.0.rc1.1.gbec44491f096
> 

[PATCH v1 3/3] watchdog: intel-mid_wdt: Get platform data via dev_get_platdata()

[Andy Shevchenko]

Access to platform data via dev_get_platdata() getter to make code cleaner.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/watchdog/intel-mid_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
index 06d5d207a065..8d71f6a2236b 100644
--- a/drivers/watchdog/intel-mid_wdt.c
+++ b/drivers/watchdog/intel-mid_wdt.c
@@ -127,7 +127,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct watchdog_device *wdt_dev;
-	struct intel_mid_wdt_pdata *pdata = dev->platform_data;
+	struct intel_mid_wdt_pdata *pdata = dev_get_platdata(dev);
 	struct mid_wdt *mid;
 	int ret;
 
-- 
2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 3/3] watchdog: intel-mid_wdt: Get platform data via dev_get_platdata()

[Guenter Roeck]

On Tue, Mar 05, 2024 at 06:52:20PM +0200, Andy Shevchenko wrote:
> Access to platform data via dev_get_platdata() getter to make code cleaner.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/intel-mid_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 06d5d207a065..8d71f6a2236b 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -127,7 +127,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct watchdog_device *wdt_dev;
> -	struct intel_mid_wdt_pdata *pdata = dev->platform_data;
> +	struct intel_mid_wdt_pdata *pdata = dev_get_platdata(dev);
>  	struct mid_wdt *mid;
>  	int ret;
>  
> -- 
> 2.43.0.rc1.1.gbec44491f096
>