* [PATCH][next] drm/msm: remove unused variable 'out'
@ 2024-03-07 9:37 Colin Ian King
2024-03-14 15:29 ` Doug Anderson
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-03-07 9:37 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, linux-arm-msm,
dri-devel, freedreno
Cc: kernel-janitors, linux-kernel
The variable out is being initialized and incremented but it is never
actually referenced in any other way. The variable is redundant and can
be removed.
Cleans up clang scan build warning:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: warning: variable
'out' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
index 1f5245fc2cdc..d4e1ebfcb021 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
@@ -840,7 +840,6 @@ static void a6xx_get_shader_block(struct msm_gpu *gpu,
struct a6xx_crashdumper *dumper)
{
u64 *in = dumper->ptr;
- u64 out = dumper->iova + A6XX_CD_DATA_OFFSET;
size_t datasize = block->size * A6XX_NUM_SHADER_BANKS * sizeof(u32);
int i;
@@ -853,8 +852,6 @@ static void a6xx_get_shader_block(struct msm_gpu *gpu,
in += CRASHDUMP_READ(in, REG_A6XX_HLSQ_DBG_AHB_READ_APERTURE,
block->size, dumper->iova + A6XX_CD_DATA_OFFSET);
-
- out += block->size * sizeof(u32);
}
CRASHDUMP_FINI(in);
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH][next] drm/msm: remove unused variable 'out'
2024-03-07 9:37 [PATCH][next] drm/msm: remove unused variable 'out' Colin Ian King
@ 2024-03-14 15:29 ` Doug Anderson
0 siblings, 0 replies; 2+ messages in thread
From: Doug Anderson @ 2024-03-14 15:29 UTC (permalink / raw)
To: Colin Ian King
Cc: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, linux-arm-msm,
dri-devel, freedreno, kernel-janitors, linux-kernel
Hi,
On Thu, Mar 7, 2024 at 1:37 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The variable out is being initialized and incremented but it is never
> actually referenced in any other way. The variable is redundant and can
> be removed.
>
> Cleans up clang scan build warning:
> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: warning: variable
> 'out' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 3 ---
> 1 file changed, 3 deletions(-)
Tested-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-14 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-07 9:37 [PATCH][next] drm/msm: remove unused variable 'out' Colin Ian King
2024-03-14 15:29 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®