* [PATCH] unicode: make utf8 test count static
@ 2024-03-08 18:32 Ben Dooks
2024-03-08 19:16 ` Gabriel Krisman Bertazi
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2024-03-08 18:32 UTC (permalink / raw)
To: linux-fsdevel; +Cc: krisman, linux-kernel, Ben Dooks
The variables failed_tests and total_tests are not used outside of the
utf8-selftest.c file so make them static to avoid the following warnings:
fs/unicode/utf8-selftest.c:17:14: warning: symbol 'failed_tests' was not declared. Should it be static?
fs/unicode/utf8-selftest.c:18:14: warning: symbol 'total_tests' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
fs/unicode/utf8-selftest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/unicode/utf8-selftest.c b/fs/unicode/utf8-selftest.c
index eb2bbdd688d7..c928e6007356 100644
--- a/fs/unicode/utf8-selftest.c
+++ b/fs/unicode/utf8-selftest.c
@@ -14,8 +14,8 @@
#include "utf8n.h"
-unsigned int failed_tests;
-unsigned int total_tests;
+static unsigned int failed_tests;
+static unsigned int total_tests;
/* Tests will be based on this version. */
#define UTF8_LATEST UNICODE_AGE(12, 1, 0)
--
2.37.2.352.g3c44437643
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] unicode: make utf8 test count static
2024-03-08 18:32 [PATCH] unicode: make utf8 test count static Ben Dooks
@ 2024-03-08 19:16 ` Gabriel Krisman Bertazi
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel Krisman Bertazi @ 2024-03-08 19:16 UTC (permalink / raw)
To: linux-fsdevel, Ben Dooks; +Cc: krisman, linux-kernel
On Fri, 08 Mar 2024 18:32:15 +0000, Ben Dooks wrote:
> The variables failed_tests and total_tests are not used outside of the
> utf8-selftest.c file so make them static to avoid the following warnings:
>
> fs/unicode/utf8-selftest.c:17:14: warning: symbol 'failed_tests' was not declared. Should it be static?
> fs/unicode/utf8-selftest.c:18:14: warning: symbol 'total_tests' was not declared. Should it be static?
>
>
> [...]
Applied, thanks!
[1/1] unicode: make utf8 test count static
commit: 0131c1f3cce7c01b0eb657a9e9e1a5e42c09a68b
Best regards,
--
Gabriel Krisman Bertazi <krisman@suse.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-08 19:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-08 18:32 [PATCH] unicode: make utf8 test count static Ben Dooks
2024-03-08 19:16 ` Gabriel Krisman Bertazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®