* [PATCH v3 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
[not found] ` <20240313015853.3573242-1-me@jwang.link>
@ 2024-03-13 1:58 ` Jiawei Wang
2024-03-13 1:58 ` [PATCH v3 2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support" Jiawei Wang
1 sibling, 0 replies; 2+ messages in thread
From: Jiawei Wang @ 2024-03-13 1:58 UTC (permalink / raw)
To: broonie
Cc: linux-sound, me, sashal, vijendar.mukunda, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Mario Limonciello, Jeremy Soller,
August Wikerfors, open list
This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc,
which added a quirk entry to enable the Yellow Carp (YC)
driver for the Lenovo 21J2 laptop.
Although the microphone functioned with the YC driver, it
resulted in incorrect driver usage. The Lenovo 21J2 is not a
Yellow Carp platform, but a Pink Sardine platform, which
already has an upstreamed driver.
The microphone on the Lenovo 21J2 operates correctly with the
CONFIG_SND_SOC_AMD_PS flag enabled and does not require the
quirk entry. So this patch removes the quirk entry.
Thanks to Mukunda Vijendar [1] for pointing this out.
Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]
Signed-off-by: Jiawei Wang <me@jwang.link>
---
sound/soc/amd/yc/acp6x-mach.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 1ab69a53174e..69c68d8e7a6b 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
}
},
- {
- .driver_data = &acp6x_card,
- .matches = {
- DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
- DMI_MATCH(DMI_PRODUCT_NAME, "21J2"),
- }
- },
{
.driver_data = &acp6x_card,
.matches = {
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH v3 2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
[not found] ` <20240313015853.3573242-1-me@jwang.link>
2024-03-13 1:58 ` [PATCH v3 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" Jiawei Wang
@ 2024-03-13 1:58 ` Jiawei Wang
1 sibling, 0 replies; 2+ messages in thread
From: Jiawei Wang @ 2024-03-13 1:58 UTC (permalink / raw)
To: broonie
Cc: linux-sound, me, sashal, vijendar.mukunda, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Syed Saba Kareem,
Vijendar Mukunda, open list
This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa,
that enabled Yellow Carp (YC) driver for PCI revision id 0x63.
Mukunda Vijendar [1] points out that revision 0x63 is Pink
Sardine platform, not Yellow Carp. The YC driver should not
be enabled for this platform. This patch prevents the YC
driver from being incorrectly enabled.
Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]
Signed-off-by: Jiawei Wang <me@jwang.link>
---
sound/soc/amd/yc/pci-acp6x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
index 694b8e313902..7af6a349b1d4 100644
--- a/sound/soc/amd/yc/pci-acp6x.c
+++ b/sound/soc/amd/yc/pci-acp6x.c
@@ -162,7 +162,6 @@ static int snd_acp6x_probe(struct pci_dev *pci,
/* Yellow Carp device check */
switch (pci->revision) {
case 0x60:
- case 0x63:
case 0x6f:
break;
default:
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread