* [PATCH] init: open output files from cpio unpacking with O_LARGEFILE
@ 2024-03-23 15:29 John Sperbeck
0 siblings, 0 replies; only message in thread
From: John Sperbeck @ 2024-03-23 15:29 UTC (permalink / raw)
To: Andrew Morton, Jens Axboe, Peter Zijlstra (Intel),
Thomas Gleixner, ndesaulniers
Cc: Randy Dunlap, linux-kernel, John Sperbeck
If a member of a cpio archive for an initrd or initrams is larger
than 2Gb, we'll eventually fail to write to that file when we
get to that limit, unless O_LARGEFILE is set.
The problem can be seen with this recipe, assuming that BLK_DEV_RAM
is not configured:
cd /tmp
dd if=/dev/zero of=BIGFILE bs=1048576 count=2200
echo BIGFILE | cpio -o -H newc -R root:root > initrd.img
kexec -l /boot/vmlinuz-$(uname -r) --initrd=initrd.img --reuse-cmdline
kexec -e
The console will show 'Initramfs unpacking failed: write error'. With
the patch, the error is gone.
Signed-off-by: John Sperbeck <jsperbeck@google.com>
---
init/initramfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/initramfs.c b/init/initramfs.c
index 76deb48c38cb..b5ede45d2f7e 100644
--- a/init/initramfs.c
+++ b/init/initramfs.c
@@ -366,7 +366,7 @@ static int __init do_name(void)
if (S_ISREG(mode)) {
int ml = maybe_link();
if (ml >= 0) {
- int openflags = O_WRONLY|O_CREAT;
+ int openflags = O_WRONLY|O_CREAT|O_LARGEFILE;
if (ml != 1)
openflags |= O_TRUNC;
wfile = filp_open(collected, openflags, mode);
--
2.44.0.396.g6e790dbe36-goog
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-23 15:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-23 15:29 [PATCH] init: open output files from cpio unpacking with O_LARGEFILE John Sperbeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®