* [PATCH] HID: Remove the unused variable minor
@ 2024-04-07 2:28 Jiapeng Chong
2024-04-12 11:38 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2024-04-07 2:28 UTC (permalink / raw)
To: jikos; +Cc: bentiss, linux-input, linux-kernel, Jiapeng Chong, Abaci Robot
Variable minor is not effectively used, so delete it.
drivers/hid/hid-winwing.c:123:15: warning: variable 'minor' set but not used.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8705
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/hid/hid-winwing.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/hid/hid-winwing.c b/drivers/hid/hid-winwing.c
index d895c82a541d..0e224d1a6466 100644
--- a/drivers/hid/hid-winwing.c
+++ b/drivers/hid/hid-winwing.c
@@ -120,7 +120,6 @@ static int winwing_init_led(struct hid_device *hdev,
static int winwing_probe(struct hid_device *hdev,
const struct hid_device_id *id)
{
- unsigned int minor;
int ret;
ret = hid_parse(hdev);
@@ -135,8 +134,6 @@ static int winwing_probe(struct hid_device *hdev,
return ret;
}
- minor = ((struct hidraw *) hdev->hidraw)->minor;
-
return 0;
}
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: Remove the unused variable minor
2024-04-07 2:28 [PATCH] HID: Remove the unused variable minor Jiapeng Chong
@ 2024-04-12 11:38 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2024-04-12 11:38 UTC (permalink / raw)
To: Jiapeng Chong
Cc: bentiss, linux-input, linux-kernel, Abaci Robot, Ivan Gorinov
On Sun, 7 Apr 2024, Jiapeng Chong wrote:
> Variable minor is not effectively used, so delete it.
>
> drivers/hid/hid-winwing.c:123:15: warning: variable 'minor' set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8705
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
I've added
Fixes: 266c990debad2 ("HID: Add WinWing Orion2 throttle support")
CCed Ivan here, and applied. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-12 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-07 2:28 [PATCH] HID: Remove the unused variable minor Jiapeng Chong
2024-04-12 11:38 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®