mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH][next] fs/direct-io: remove redundant assignment to variable retval
@ 2024-04-10 16:22 Colin Ian King
  2024-04-10 17:45 ` Jan Kara
  2024-04-11  8:21 ` Christian Brauner
  0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-04-10 16:22 UTC (permalink / raw)
  To: Alexander Viro, Christian Brauner, Jan Kara, linux-fsdevel
  Cc: kernel-janitors, linux-kernel

The variable retval is being assigned a value that is not being read,
it is being re-assigned later on in the function. The assignment
is redundant and can be removed.

Cleans up clang scan build warning:
fs/direct-io.c:1220:2: warning: Value stored to 'retval' is never
read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/direct-io.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/direct-io.c b/fs/direct-io.c
index 62c97ff9e852..b0aafe640fa4 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -1217,7 +1217,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
 	 */
 	inode_dio_begin(inode);
 
-	retval = 0;
 	sdio.blkbits = blkbits;
 	sdio.blkfactor = i_blkbits - blkbits;
 	sdio.block_in_file = offset >> blkbits;
-- 
2.39.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][next] fs/direct-io: remove redundant assignment to variable retval
  2024-04-10 16:22 [PATCH][next] fs/direct-io: remove redundant assignment to variable retval Colin Ian King
@ 2024-04-10 17:45 ` Jan Kara
  2024-04-11  8:21 ` Christian Brauner
  1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2024-04-10 17:45 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Alexander Viro, Christian Brauner, Jan Kara, linux-fsdevel,
	kernel-janitors, linux-kernel

On Wed 10-04-24 17:22:21, Colin Ian King wrote:
> The variable retval is being assigned a value that is not being read,
> it is being re-assigned later on in the function. The assignment
> is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> fs/direct-io.c:1220:2: warning: Value stored to 'retval' is never
> read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Indeed it's assigned a few lines below. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/direct-io.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index 62c97ff9e852..b0aafe640fa4 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -1217,7 +1217,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
>  	 */
>  	inode_dio_begin(inode);
>  
> -	retval = 0;
>  	sdio.blkbits = blkbits;
>  	sdio.blkfactor = i_blkbits - blkbits;
>  	sdio.block_in_file = offset >> blkbits;
> -- 
> 2.39.2
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][next] fs/direct-io: remove redundant assignment to variable retval
  2024-04-10 16:22 [PATCH][next] fs/direct-io: remove redundant assignment to variable retval Colin Ian King
  2024-04-10 17:45 ` Jan Kara
@ 2024-04-11  8:21 ` Christian Brauner
  1 sibling, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2024-04-11  8:21 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Christian Brauner, kernel-janitors, linux-kernel, Alexander Viro,
	Jan Kara, linux-fsdevel

On Wed, 10 Apr 2024 17:22:21 +0100, Colin Ian King wrote:
> The variable retval is being assigned a value that is not being read,
> it is being re-assigned later on in the function. The assignment
> is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> fs/direct-io.c:1220:2: warning: Value stored to 'retval' is never
> read [deadcode.DeadStores]
> 
> [...]

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] fs/direct-io: remove redundant assignment to variable retval
      https://git.kernel.org/vfs/vfs/c/fd0a133ef6ed

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-11  8:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-10 16:22 [PATCH][next] fs/direct-io: remove redundant assignment to variable retval Colin Ian King
2024-04-10 17:45 ` Jan Kara
2024-04-11  8:21 ` Christian Brauner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®