From: Ye Bin <yebin10@huawei.com>
To: <alex.williamson@redhat.com>, <kevin.tian@intel.com>,
<reinette.chatre@intel.com>, <tglx@linutronix.de>,
<brauner@kernel.org>, <yebin10@huawei.com>, <kvm@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()
Date: Mon, 15 Apr 2024 09:50:29 +0800 [thread overview]
Message-ID: <20240415015029.3699844-1-yebin10@huawei.com> (raw)
If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
drivers/vfio/pci/vfio_pci_intrs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index fb5392b749ff..e80c5d75b541 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -277,8 +277,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev,
return -ENOMEM;
ctx = vfio_irq_ctx_alloc(vdev, 0);
- if (!ctx)
+ if (!ctx) {
+ kfree(name);
return -ENOMEM;
+ }
ctx->name = name;
ctx->trigger = trigger;
--
2.31.1
next reply other threads:[~2024-04-15 1:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 1:50 Ye Bin [this message]
2024-04-17 5:02 ` Tian, Kevin
2024-04-18 3:17 ` Reinette Chatre
2024-04-23 20:25 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415015029.3699844-1-yebin10@huawei.com \
--to=yebin10@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=brauner@kernel.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®