* [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()
@ 2024-04-15 1:50 Ye Bin
2024-04-17 5:02 ` Tian, Kevin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ye Bin @ 2024-04-15 1:50 UTC (permalink / raw)
To: alex.williamson, kevin.tian, reinette.chatre, tglx, brauner,
yebin10, kvm
Cc: linux-kernel
If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
drivers/vfio/pci/vfio_pci_intrs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index fb5392b749ff..e80c5d75b541 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -277,8 +277,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev,
return -ENOMEM;
ctx = vfio_irq_ctx_alloc(vdev, 0);
- if (!ctx)
+ if (!ctx) {
+ kfree(name);
return -ENOMEM;
+ }
ctx->name = name;
ctx->trigger = trigger;
--
2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()
2024-04-15 1:50 [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable() Ye Bin
@ 2024-04-17 5:02 ` Tian, Kevin
2024-04-18 3:17 ` Reinette Chatre
2024-04-23 20:25 ` Alex Williamson
2 siblings, 0 replies; 4+ messages in thread
From: Tian, Kevin @ 2024-04-17 5:02 UTC (permalink / raw)
To: Ye Bin, alex.williamson, Chatre, Reinette, tglx, brauner, kvm
Cc: linux-kernel
> From: Ye Bin <yebin10@huawei.com>
> Sent: Monday, April 15, 2024 9:50 AM
>
> If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
>
> Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
> Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()
2024-04-15 1:50 [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable() Ye Bin
2024-04-17 5:02 ` Tian, Kevin
@ 2024-04-18 3:17 ` Reinette Chatre
2024-04-23 20:25 ` Alex Williamson
2 siblings, 0 replies; 4+ messages in thread
From: Reinette Chatre @ 2024-04-18 3:17 UTC (permalink / raw)
To: Ye Bin, alex.williamson, kevin.tian, tglx, brauner, kvm; +Cc: linux-kernel
On 4/14/2024 6:50 PM, Ye Bin wrote:
> If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
>
> Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
Thank you for catching this.
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable()
2024-04-15 1:50 [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable() Ye Bin
2024-04-17 5:02 ` Tian, Kevin
2024-04-18 3:17 ` Reinette Chatre
@ 2024-04-23 20:25 ` Alex Williamson
2 siblings, 0 replies; 4+ messages in thread
From: Alex Williamson @ 2024-04-23 20:25 UTC (permalink / raw)
To: Ye Bin; +Cc: kevin.tian, reinette.chatre, tglx, brauner, kvm, linux-kernel
On Mon, 15 Apr 2024 09:50:29 +0800
Ye Bin <yebin10@huawei.com> wrote:
> If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.
>
> Fixes: 18c198c96a81 ("vfio/pci: Create persistent INTx handler")
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> ---
> drivers/vfio/pci/vfio_pci_intrs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to vfio next branch for v6.10. Thanks!
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-23 20:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-15 1:50 [PATCH] vfio/pci: fix potential memory leak in vfio_intx_enable() Ye Bin
2024-04-17 5:02 ` Tian, Kevin
2024-04-18 3:17 ` Reinette Chatre
2024-04-23 20:25 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®