[PATCH v2 0/2] Fix UART pin type and macro type

[PATCH v2 0/2] Fix UART pin type and macro type

[Udit Kumar]

This series fixes UART pin mux for J784s4-evm and am69.
Along with replacing pin mux macro of J784S4 SOC instead of J721S2.

Test logs
https://gist.github.com/uditkumarti/a28ec171732e32c16b2666c27093c115

For fixes, these errors should be caught during review but missed due to
cross reference is taken from tool's output.
Note to self, don't always rely on tool's output while reviewing the patch.


Change logs:
Changes in v2:
Splitting patch series into two as refactoring and fixes,
This series is for fixes, refactoring will be sent later
Link of v1: https://lore.kernel.org/all/20240415063329.3286600-1-u-kumar1@ti.com/


Udit Kumar (2):
  arm64: dts: ti: k3-j784s4-evm: Fix UART pin type and macro type
  arm64: dts: ti: k3-am69-sk: Fix UART pin type and macro type

 arch/arm64/boot/dts/ti/k3-am69-sk.dts    | 12 ++++++------
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts |  8 ++++----
 2 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.34.1

[PATCH v2 1/2] arm64: dts: ti: k3-j784s4-evm: Fix UART pin type and macro type

[Udit Kumar]

Along fixing wkup UART TX pin as OUTPUT instead of INPUT,
updating J784S4 macro for pin mux instead of J721S2.

Fixes: 5dfbd1debc8c ("arm64: dts: ti: k3-j784s4-evm: Enable wakeup_i2c0 and eeprom")
Fixes: 6fa5d37a2f34 ("arm64: dts: ti: k3-j784s4-evm: Add mcu and wakeup uarts")
Signed-off-by: Udit Kumar <u-kumar1@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index 81fd7afac8c5..d511b25d62e3 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -343,16 +343,16 @@ &wkup_pmx2 {
 	wkup_uart0_pins_default: wkup-uart0-default-pins {
 		bootph-all;
 		pinctrl-single,pins = <
-			J721S2_WKUP_IOPAD(0x048, PIN_INPUT, 0) /* (K35) WKUP_UART0_RXD */
-			J721S2_WKUP_IOPAD(0x04c, PIN_INPUT, 0) /* (K34) WKUP_UART0_TXD */
+			J784S4_WKUP_IOPAD(0x048, PIN_INPUT, 0) /* (K35) WKUP_UART0_RXD */
+			J784S4_WKUP_IOPAD(0x04c, PIN_OUTPUT, 0) /* (K34) WKUP_UART0_TXD */
 		>;
 	};
 
 	wkup_i2c0_pins_default: wkup-i2c0-default-pins {
 		bootph-all;
 		pinctrl-single,pins = <
-			J721S2_WKUP_IOPAD(0x98, PIN_INPUT, 0) /* (N33) WKUP_I2C0_SCL */
-			J721S2_WKUP_IOPAD(0x9c, PIN_INPUT, 0) /* (N35) WKUP_I2C0_SDA */
+			J784S4_WKUP_IOPAD(0x98, PIN_INPUT, 0) /* (N33) WKUP_I2C0_SCL */
+			J784S4_WKUP_IOPAD(0x9c, PIN_INPUT, 0) /* (N35) WKUP_I2C0_SDA */
 		>;
 	};
 
-- 
2.34.1

Re: [PATCH v2 1/2] arm64: dts: ti: k3-j784s4-evm: Fix UART pin type and macro type

[Francesco Dolcini]

On Mon, Apr 15, 2024 at 03:26:04PM +0530, Udit Kumar wrote:
> Along fixing wkup UART TX pin as OUTPUT instead of INPUT,
> updating J784S4 macro for pin mux instead of J721S2.
> 
> Fixes: 5dfbd1debc8c ("arm64: dts: ti: k3-j784s4-evm: Enable wakeup_i2c0 and eeprom")
> Fixes: 6fa5d37a2f34 ("arm64: dts: ti: k3-j784s4-evm: Add mcu and wakeup uarts")
> Signed-off-by: Udit Kumar <u-kumar1@ti.com>

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

[PATCH v2 2/2] arm64: dts: ti: k3-am69-sk: Fix UART pin type and macro type

[Udit Kumar]

Along fixing wkup UART RTS and TX pins as OUTPUT instead of INPUT
updating J784S4 macro for pin mux instead of J721S2.

Fixes: 45299dd1991b ("arm64: dts: ti: k3-am69-sk: Add mcu and wakeup uarts")
Fixes: 08ae12b63750 ("arm64: dts: ti: k3-am69-sk: Enable wakeup_i2c0 and eeprom")
Signed-off-by: Udit Kumar <u-kumar1@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am69-sk.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
index 50de2a448a3a..d88651c297a2 100644
--- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
@@ -517,18 +517,18 @@ J784S4_WKUP_IOPAD(0x0fc, PIN_INPUT, 7)
 	wkup_uart0_pins_default: wkup-uart0-default-pins {
 		bootph-all;
 		pinctrl-single,pins = <
-			J721S2_WKUP_IOPAD(0x070, PIN_INPUT, 0) /* (L37) WKUP_GPIO0_6.WKUP_UART0_CTSn */
-			J721S2_WKUP_IOPAD(0x074, PIN_INPUT, 0) /* (L36) WKUP_GPIO0_7.WKUP_UART0_RTSn */
-			J721S2_WKUP_IOPAD(0x048, PIN_INPUT, 0) /* (K35) WKUP_UART0_RXD */
-			J721S2_WKUP_IOPAD(0x04c, PIN_INPUT, 0) /* (K34) WKUP_UART0_TXD */
+			J784S4_WKUP_IOPAD(0x070, PIN_INPUT, 0) /* (L37) WKUP_UART0_CTSn */
+			J784S4_WKUP_IOPAD(0x074, PIN_OUTPUT, 0) /* (L36) WKUP_UART0_RTSn */
+			J784S4_WKUP_IOPAD(0x048, PIN_INPUT, 0) /* (K35) WKUP_UART0_RXD */
+			J784S4_WKUP_IOPAD(0x04c, PIN_OUTPUT, 0) /* (K34) WKUP_UART0_TXD */
 		>;
 	};
 
 	wkup_i2c0_pins_default: wkup-i2c0-default-pins {
 		bootph-all;
 		pinctrl-single,pins = <
-			J721S2_WKUP_IOPAD(0x98, PIN_INPUT, 0) /* (N33) WKUP_I2C0_SCL */
-			J721S2_WKUP_IOPAD(0x9c, PIN_INPUT, 0) /* (N35) WKUP_I2C0_SDA */
+			J784S4_WKUP_IOPAD(0x98, PIN_INPUT, 0) /* (N33) WKUP_I2C0_SCL */
+			J784S4_WKUP_IOPAD(0x9c, PIN_INPUT, 0) /* (N35) WKUP_I2C0_SDA */
 		>;
 	};
 
-- 
2.34.1

Re: [PATCH v2 2/2] arm64: dts: ti: k3-am69-sk: Fix UART pin type and macro type

[Francesco Dolcini]

On Mon, Apr 15, 2024 at 03:26:05PM +0530, Udit Kumar wrote:
> Along fixing wkup UART RTS and TX pins as OUTPUT instead of INPUT
> updating J784S4 macro for pin mux instead of J721S2.
> 
> Fixes: 45299dd1991b ("arm64: dts: ti: k3-am69-sk: Add mcu and wakeup uarts")
> Fixes: 08ae12b63750 ("arm64: dts: ti: k3-am69-sk: Enable wakeup_i2c0 and eeprom")
> Signed-off-by: Udit Kumar <u-kumar1@ti.com>

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Re: [PATCH v2 0/2] Fix UART pin type and macro type

[Nishanth Menon]

Hi Udit Kumar,

On Mon, 15 Apr 2024 15:26:03 +0530, Udit Kumar wrote:
> This series fixes UART pin mux for J784s4-evm and am69.
> Along with replacing pin mux macro of J784S4 SOC instead of J721S2.
> 
> Test logs
> https://gist.github.com/uditkumarti/a28ec171732e32c16b2666c27093c115
> 
> For fixes, these errors should be caught during review but missed due to
> cross reference is taken from tool's output.
> Note to self, don't always rely on tool's output while reviewing the patch.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/2] arm64: dts: ti: k3-j784s4-evm: Fix UART pin type and macro type
      commit: d79fc91456338f42e9066cff91e3b4ea174986d4
[2/2] arm64: dts: ti: k3-am69-sk: Fix UART pin type and macro type
      commit: e1818f04eff632bad803f85d24dbfbfa3ddb5218

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D