* [PATCH v2] fpga: dfl: remove unused function is_dfl_feature_present
@ 2024-04-15 23:57 Peter Colberg
2024-04-19 7:52 ` Xu Yilun
0 siblings, 1 reply; 2+ messages in thread
From: Peter Colberg @ 2024-04-15 23:57 UTC (permalink / raw)
To: Wu Hao, Tom Rix, Moritz Fischer, Xu Yilun, linux-fpga, linux-kernel
Cc: Russ Weight, Marco Pagani, Matthew Gerlach, Peter Colberg
The function is_dfl_feature_present was added but never used.
Fixes: 5b57d02a2f94 ("fpga: dfl: add feature device infrastructure")
Signed-off-by: Peter Colberg <peter.colberg@intel.com>
Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
---
v2:
- Do not wrap commit reference and move to Fixes: tag.
---
drivers/fpga/dfl.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
index 1d724a28f00a..5063d73b0d82 100644
--- a/drivers/fpga/dfl.h
+++ b/drivers/fpga/dfl.h
@@ -437,11 +437,6 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
return NULL;
}
-static inline bool is_dfl_feature_present(struct device *dev, u16 id)
-{
- return !!dfl_get_feature_ioaddr_by_id(dev, id);
-}
-
static inline
struct device *dfl_fpga_pdata_to_parent(struct dfl_feature_platform_data *pdata)
{
--
2.44.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] fpga: dfl: remove unused function is_dfl_feature_present
2024-04-15 23:57 [PATCH v2] fpga: dfl: remove unused function is_dfl_feature_present Peter Colberg
@ 2024-04-19 7:52 ` Xu Yilun
0 siblings, 0 replies; 2+ messages in thread
From: Xu Yilun @ 2024-04-19 7:52 UTC (permalink / raw)
To: Peter Colberg
Cc: Wu Hao, Tom Rix, Moritz Fischer, Xu Yilun, linux-fpga,
linux-kernel, Russ Weight, Marco Pagani, Matthew Gerlach
On Mon, Apr 15, 2024 at 07:57:43PM -0400, Peter Colberg wrote:
> The function is_dfl_feature_present was added but never used.
^
Function reference should use the format "function_name()", I fixed it
in place.
Applied to for-next.
>
> Fixes: 5b57d02a2f94 ("fpga: dfl: add feature device infrastructure")
> Signed-off-by: Peter Colberg <peter.colberg@intel.com>
> Reviewed-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> ---
> v2:
> - Do not wrap commit reference and move to Fixes: tag.
> ---
> drivers/fpga/dfl.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 1d724a28f00a..5063d73b0d82 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -437,11 +437,6 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
> return NULL;
> }
>
> -static inline bool is_dfl_feature_present(struct device *dev, u16 id)
> -{
> - return !!dfl_get_feature_ioaddr_by_id(dev, id);
> -}
> -
> static inline
> struct device *dfl_fpga_pdata_to_parent(struct dfl_feature_platform_data *pdata)
> {
> --
> 2.44.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-19 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-15 23:57 [PATCH v2] fpga: dfl: remove unused function is_dfl_feature_present Peter Colberg
2024-04-19 7:52 ` Xu Yilun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®