* [PATCH] lockd: host: Remove unnecessary statements＇host = NULL;＇
@ 2024-04-17 8:28 Li kunyu
2024-04-17 10:06 ` Jeff Layton
2024-04-17 16:28 ` Chuck Lever
0 siblings, 2 replies; 3+ messages in thread
From: Li kunyu @ 2024-04-17 8:28 UTC (permalink / raw)
To: chuck.lever, jlayton, neilb, kolga, Dai.Ngo, tom, trond.myklebust, anna
Cc: linux-nfs, linux-kernel, Li kunyu
In 'nlm_alloc_host', the host has already been assigned a value of NULL
when defined, so 'host=NULL;' Can be deleted.
Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
fs/lockd/host.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/lockd/host.c b/fs/lockd/host.c
index 127a728fcbc81..c115168017845 100644
--- a/fs/lockd/host.c
+++ b/fs/lockd/host.c
@@ -117,7 +117,6 @@ static struct nlm_host *nlm_alloc_host(struct nlm_lookup_host_info *ni,
if (nsm != NULL)
refcount_inc(&nsm->sm_count);
else {
- host = NULL;
nsm = nsm_get_handle(ni->net, ni->sap, ni->salen,
ni->hostname, ni->hostname_len);
if (unlikely(nsm == NULL)) {
--
2.18.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] lockd: host: Remove unnecessary statements＇host = NULL;＇
2024-04-17 8:28 [PATCH] lockd: host: Remove unnecessary statements＇host = NULL;＇ Li kunyu
@ 2024-04-17 10:06 ` Jeff Layton
2024-04-17 16:28 ` Chuck Lever
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2024-04-17 10:06 UTC (permalink / raw)
To: Li kunyu, chuck.lever, neilb, kolga, Dai.Ngo, tom, trond.myklebust, anna
Cc: linux-nfs, linux-kernel
On Wed, 2024-04-17 at 16:28 +0800, Li kunyu wrote:
> In 'nlm_alloc_host', the host has already been assigned a value of NULL
> when defined, so 'host=NULL;' Can be deleted.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> fs/lockd/host.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/lockd/host.c b/fs/lockd/host.c
> index 127a728fcbc81..c115168017845 100644
> --- a/fs/lockd/host.c
> +++ b/fs/lockd/host.c
> @@ -117,7 +117,6 @@ static struct nlm_host *nlm_alloc_host(struct nlm_lookup_host_info *ni,
> if (nsm != NULL)
> refcount_inc(&nsm->sm_count);
> else {
> - host = NULL;
> nsm = nsm_get_handle(ni->net, ni->sap, ni->salen,
> ni->hostname, ni->hostname_len);
> if (unlikely(nsm == NULL)) {
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] lockd: host: Remove unnecessary statements＇host = NULL;＇
2024-04-17 8:28 [PATCH] lockd: host: Remove unnecessary statements＇host = NULL;＇ Li kunyu
2024-04-17 10:06 ` Jeff Layton
@ 2024-04-17 16:28 ` Chuck Lever
1 sibling, 0 replies; 3+ messages in thread
From: Chuck Lever @ 2024-04-17 16:28 UTC (permalink / raw)
To: Li kunyu
Cc: jlayton, neilb, kolga, Dai.Ngo, tom, trond.myklebust, anna,
linux-nfs, linux-kernel
On Wed, Apr 17, 2024 at 04:28:07PM +0800, Li kunyu wrote:
> In 'nlm_alloc_host', the host has already been assigned a value of NULL
> when defined, so 'host=NULL;' Can be deleted.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> fs/lockd/host.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/lockd/host.c b/fs/lockd/host.c
> index 127a728fcbc81..c115168017845 100644
> --- a/fs/lockd/host.c
> +++ b/fs/lockd/host.c
> @@ -117,7 +117,6 @@ static struct nlm_host *nlm_alloc_host(struct nlm_lookup_host_info *ni,
> if (nsm != NULL)
> refcount_inc(&nsm->sm_count);
> else {
> - host = NULL;
> nsm = nsm_get_handle(ni->net, ni->sap, ni->salen,
> ni->hostname, ni->hostname_len);
> if (unlikely(nsm == NULL)) {
> --
> 2.18.2
>
Thanks for the clean up! Applied to nfsd-next (for v6.10).
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-17 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 8:28 [PATCH] lockd: host: Remove unnecessary statements＇host = NULL;＇ Li kunyu
2024-04-17 10:06 ` Jeff Layton
2024-04-17 16:28 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®