* [PATCH] media: mceusb: No need for vendor/product ID in name
@ 2024-04-29 13:32 Sean Young
0 siblings, 0 replies; only message in thread
From: Sean Young @ 2024-04-29 13:32 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel
This is available in other places and doesn't belong in the name
of the rc device.
Signed-off-by: Sean Young <sean@mess.org>
---
drivers/media/rc/mceusb.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index c76ba24c1f55..8e804f41e083 100644
--- a/drivers/media/rc/mceusb.c
+++ b/drivers/media/rc/mceusb.c
@@ -494,7 +494,7 @@ struct mceusb_dev {
u32 carrier;
unsigned char tx_mask;
- char name[128];
+ const char *name;
char phys[64];
enum mceusb_model_type model;
@@ -1591,12 +1591,8 @@ static struct rc_dev *mceusb_init_rc_dev(struct mceusb_dev *ir)
goto out;
}
- snprintf(ir->name, sizeof(ir->name), "%s (%04x:%04x)",
- mceusb_model[ir->model].name ?
- mceusb_model[ir->model].name :
- "Media Center Ed. eHome Infrared Remote Transceiver",
- le16_to_cpu(ir->usbdev->descriptor.idVendor),
- le16_to_cpu(ir->usbdev->descriptor.idProduct));
+ ir->name = mceusb_model[ir->model].name ? :
+ "Media Center Ed. eHome Infrared Remote Transceiver";
usb_make_path(ir->usbdev, ir->phys, sizeof(ir->phys));
--
2.44.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-29 13:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-29 13:32 [PATCH] media: mceusb: No need for vendor/product ID in name Sean Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®