* [PATCH] drm/msm/dpu: guard ctl irq callback register/unregister
@ 2024-05-09 17:52 Barnabás Czémán
2024-05-09 19:14 ` Abhinav Kumar
2024-06-23 7:14 ` Dmitry Baryshkov
0 siblings, 2 replies; 5+ messages in thread
From: Barnabás Czémán @ 2024-05-09 17:52 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel,
Barnabás Czémán
CTLs on older qualcomm SOCs like msm8953 and msm8996 has not got interrupts,
so better to skip CTL irq callback register/unregister
make dpu_ctl_cfg be able to define without intr_start.
Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
index 489be1c0c704..250d83af53a4 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
@@ -298,7 +298,7 @@ static void dpu_encoder_phys_cmd_irq_enable(struct dpu_encoder_phys *phys_enc)
phys_enc);
dpu_encoder_phys_cmd_control_vblank_irq(phys_enc, true);
- if (dpu_encoder_phys_cmd_is_master(phys_enc))
+ if (dpu_encoder_phys_cmd_is_master(phys_enc) && phys_enc->irq[INTR_IDX_CTL_START])
dpu_core_irq_register_callback(phys_enc->dpu_kms,
phys_enc->irq[INTR_IDX_CTL_START],
dpu_encoder_phys_cmd_ctl_start_irq,
@@ -311,7 +311,7 @@ static void dpu_encoder_phys_cmd_irq_disable(struct dpu_encoder_phys *phys_enc)
phys_enc->hw_pp->idx - PINGPONG_0,
phys_enc->vblank_refcount);
- if (dpu_encoder_phys_cmd_is_master(phys_enc))
+ if (dpu_encoder_phys_cmd_is_master(phys_enc) && phys_enc->irq[INTR_IDX_CTL_START])
dpu_core_irq_unregister_callback(phys_enc->dpu_kms,
phys_enc->irq[INTR_IDX_CTL_START]);
---
base-commit: 704ba27ac55579704ba1289392448b0c66b56258
change-id: 20240509-ctl_irq-a90b2d7a0bf5
Best regards,
--
Barnabás Czémán <trabarni@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/msm/dpu: guard ctl irq callback register/unregister
2024-05-09 17:52 [PATCH] drm/msm/dpu: guard ctl irq callback register/unregister Barnabás Czémán
@ 2024-05-09 19:14 ` Abhinav Kumar
2024-05-09 19:27 ` Barnabás Czémán
2024-06-22 11:39 ` Dmitry Baryshkov
2024-06-23 7:14 ` Dmitry Baryshkov
1 sibling, 2 replies; 5+ messages in thread
From: Abhinav Kumar @ 2024-05-09 19:14 UTC (permalink / raw)
To: Barnabás Czémán, Rob Clark, Dmitry Baryshkov,
Sean Paul, Marijn Suijten, David Airlie, Daniel Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 5/9/2024 10:52 AM, Barnabás Czémán wrote:
> CTLs on older qualcomm SOCs like msm8953 and msm8996 has not got interrupts,
> so better to skip CTL irq callback register/unregister
> make dpu_ctl_cfg be able to define without intr_start.
>
Thanks for the patch.
Have msm8953 and msm8996 migrated to DPU or is there a series planned to
migrate them?
The change itself is correct but without the catalogs for those chipsets
merged, we will never hit this path.
> Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index 489be1c0c704..250d83af53a4 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -298,7 +298,7 @@ static void dpu_encoder_phys_cmd_irq_enable(struct dpu_encoder_phys *phys_enc)
> phys_enc);
> dpu_encoder_phys_cmd_control_vblank_irq(phys_enc, true);
>
> - if (dpu_encoder_phys_cmd_is_master(phys_enc))
> + if (dpu_encoder_phys_cmd_is_master(phys_enc) && phys_enc->irq[INTR_IDX_CTL_START])
> dpu_core_irq_register_callback(phys_enc->dpu_kms,
> phys_enc->irq[INTR_IDX_CTL_START],
> dpu_encoder_phys_cmd_ctl_start_irq,
> @@ -311,7 +311,7 @@ static void dpu_encoder_phys_cmd_irq_disable(struct dpu_encoder_phys *phys_enc)
> phys_enc->hw_pp->idx - PINGPONG_0,
> phys_enc->vblank_refcount);
>
> - if (dpu_encoder_phys_cmd_is_master(phys_enc))
> + if (dpu_encoder_phys_cmd_is_master(phys_enc) && phys_enc->irq[INTR_IDX_CTL_START])
> dpu_core_irq_unregister_callback(phys_enc->dpu_kms,
> phys_enc->irq[INTR_IDX_CTL_START]);
>
>
> ---
> base-commit: 704ba27ac55579704ba1289392448b0c66b56258
> change-id: 20240509-ctl_irq-a90b2d7a0bf5
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/msm/dpu: guard ctl irq callback register/unregister
2024-05-09 19:14 ` Abhinav Kumar
@ 2024-05-09 19:27 ` Barnabás Czémán
2024-06-22 11:39 ` Dmitry Baryshkov
1 sibling, 0 replies; 5+ messages in thread
From: Barnabás Czémán @ 2024-05-09 19:27 UTC (permalink / raw)
To: Abhinav Kumar
Cc: Rob Clark, Dmitry Baryshkov, Sean Paul, Marijn Suijten,
David Airlie, Daniel Vetter, linux-arm-msm, dri-devel, freedreno,
linux-kernel
There was some previously sent patch series made by Dmitry for these soc,
msm8996 was sent together by sdm660 but in the last version it was dropped.
I have recreated msm8996 DPU support from that series but it will need
some more test.
I am testing msm8953 series but it is depend on msm8996.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/msm/dpu: guard ctl irq callback register/unregister
2024-05-09 19:14 ` Abhinav Kumar
2024-05-09 19:27 ` Barnabás Czémán
@ 2024-06-22 11:39 ` Dmitry Baryshkov
1 sibling, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-06-22 11:39 UTC (permalink / raw)
To: Abhinav Kumar
Cc: Barnabás Czémán, Rob Clark, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, linux-arm-msm,
dri-devel, freedreno, linux-kernel
On Thu, May 09, 2024 at 12:14:19PM GMT, Abhinav Kumar wrote:
>
>
> On 5/9/2024 10:52 AM, Barnabás Czémán wrote:
> > CTLs on older qualcomm SOCs like msm8953 and msm8996 has not got interrupts,
> > so better to skip CTL irq callback register/unregister
> > make dpu_ctl_cfg be able to define without intr_start.
> >
>
> Thanks for the patch.
>
> Have msm8953 and msm8996 migrated to DPU or is there a series planned to
> migrate them?
>
> The change itself is correct but without the catalogs for those chipsets
> merged, we will never hit this path.
I think I'm going to accept this patch. While we might not be supporting
these chipsets, it's easier to have this in.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
> > ---
> > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> > index 489be1c0c704..250d83af53a4 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> > @@ -298,7 +298,7 @@ static void dpu_encoder_phys_cmd_irq_enable(struct dpu_encoder_phys *phys_enc)
> > phys_enc);
> > dpu_encoder_phys_cmd_control_vblank_irq(phys_enc, true);
> > - if (dpu_encoder_phys_cmd_is_master(phys_enc))
> > + if (dpu_encoder_phys_cmd_is_master(phys_enc) && phys_enc->irq[INTR_IDX_CTL_START])
> > dpu_core_irq_register_callback(phys_enc->dpu_kms,
> > phys_enc->irq[INTR_IDX_CTL_START],
> > dpu_encoder_phys_cmd_ctl_start_irq,
> > @@ -311,7 +311,7 @@ static void dpu_encoder_phys_cmd_irq_disable(struct dpu_encoder_phys *phys_enc)
> > phys_enc->hw_pp->idx - PINGPONG_0,
> > phys_enc->vblank_refcount);
> > - if (dpu_encoder_phys_cmd_is_master(phys_enc))
> > + if (dpu_encoder_phys_cmd_is_master(phys_enc) && phys_enc->irq[INTR_IDX_CTL_START])
> > dpu_core_irq_unregister_callback(phys_enc->dpu_kms,
> > phys_enc->irq[INTR_IDX_CTL_START]);
> >
> > ---
> > base-commit: 704ba27ac55579704ba1289392448b0c66b56258
> > change-id: 20240509-ctl_irq-a90b2d7a0bf5
> >
> > Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/msm/dpu: guard ctl irq callback register/unregister
2024-05-09 17:52 [PATCH] drm/msm/dpu: guard ctl irq callback register/unregister Barnabás Czémán
2024-05-09 19:14 ` Abhinav Kumar
@ 2024-06-23 7:14 ` Dmitry Baryshkov
1 sibling, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-06-23 7:14 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Sean Paul, Marijn Suijten,
David Airlie, Daniel Vetter, Barnabás Czémán
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On Thu, 09 May 2024 19:52:04 +0200, Barnabás Czémán wrote:
> CTLs on older qualcomm SOCs like msm8953 and msm8996 has not got interrupts,
> so better to skip CTL irq callback register/unregister
> make dpu_ctl_cfg be able to define without intr_start.
>
>
Applied, thanks!
[1/1] drm/msm/dpu: guard ctl irq callback register/unregister
https://gitlab.freedesktop.org/lumag/msm/-/commit/29cd76c6f897
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-06-23 7:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-09 17:52 [PATCH] drm/msm/dpu: guard ctl irq callback register/unregister Barnabás Czémán
2024-05-09 19:14 ` Abhinav Kumar
2024-05-09 19:27 ` Barnabás Czémán
2024-06-22 11:39 ` Dmitry Baryshkov
2024-06-23 7:14 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®