mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: btsdio: Do not bind to non-removable CYW4373
@ 2024-05-13 16:22 Tim Harvey
  2024-06-17 23:00 ` Tim Harvey
  0 siblings, 1 reply; 2+ messages in thread
From: Tim Harvey @ 2024-05-13 16:22 UTC (permalink / raw)
  To: Marcel Holtmann, Luiz Augusto von Dentz, linux-bluetooth, linux-kernel
  Cc: Scott Ehlert, Tim Harvey

From: Scott Ehlert <ehlert@battelle.org>

CYW4373 devices soldered onto the PCB (non-removable),
use a UART connection for Bluetooth and the advertised btsdio
support as an SDIO function should be ignored.

Signed-off-by: Scott Ehlert <ehlert@battelle.org>
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 drivers/bluetooth/btsdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
index f19d31ee37ea..bc9631bddc40 100644
--- a/drivers/bluetooth/btsdio.c
+++ b/drivers/bluetooth/btsdio.c
@@ -298,6 +298,7 @@ static int btsdio_probe(struct sdio_func *func,
 		case SDIO_DEVICE_ID_BROADCOM_4345:
 		case SDIO_DEVICE_ID_BROADCOM_43455:
 		case SDIO_DEVICE_ID_BROADCOM_4356:
+		case SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373:
 			return -ENODEV;
 		}
 	}
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: btsdio: Do not bind to non-removable CYW4373
  2024-05-13 16:22 [PATCH] Bluetooth: btsdio: Do not bind to non-removable CYW4373 Tim Harvey
@ 2024-06-17 23:00 ` Tim Harvey
  0 siblings, 0 replies; 2+ messages in thread
From: Tim Harvey @ 2024-06-17 23:00 UTC (permalink / raw)
  To: Marcel Holtmann, Luiz Augusto von Dentz, linux-bluetooth, linux-kernel
  Cc: Scott Ehlert

On Mon, May 13, 2024 at 9:22 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> From: Scott Ehlert <ehlert@battelle.org>
>
> CYW4373 devices soldered onto the PCB (non-removable),
> use a UART connection for Bluetooth and the advertised btsdio
> support as an SDIO function should be ignored.
>
> Signed-off-by: Scott Ehlert <ehlert@battelle.org>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  drivers/bluetooth/btsdio.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
> index f19d31ee37ea..bc9631bddc40 100644
> --- a/drivers/bluetooth/btsdio.c
> +++ b/drivers/bluetooth/btsdio.c
> @@ -298,6 +298,7 @@ static int btsdio_probe(struct sdio_func *func,
>                 case SDIO_DEVICE_ID_BROADCOM_4345:
>                 case SDIO_DEVICE_ID_BROADCOM_43455:
>                 case SDIO_DEVICE_ID_BROADCOM_4356:
> +               case SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373:
>                         return -ENODEV;
>                 }
>         }
> --
> 2.25.1
>

Greetings,

It seems that this patch got archived due to failure of an automated
test. The failure doesn't appear to me to have anything to do with the
code change or perhaps I'm just not understanding the error:
https://patchwork.kernel.org/project/bluetooth/patch/20240513162200.2658571-1-tharvey@gateworks.com/

Is there something I need to do here?

Best Regards,

Tim

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-17 23:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-13 16:22 [PATCH] Bluetooth: btsdio: Do not bind to non-removable CYW4373 Tim Harvey
2024-06-17 23:00 ` Tim Harvey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®