* [PATCH] PCI: endpoint: Remove some unused fields in struct pci_epf_group
@ 2024-04-05 18:16 Christophe JAILLET
2024-05-17 11:08 ` Krzysztof Wilczyński
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-04-05 18:16 UTC (permalink / raw)
To: Manivannan Sadhasivam, Krzysztof Wilczyński,
Kishon Vijay Abraham I, Bjorn Helgaas
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-pci
In "struct pci_epf_group", the 'type_group' field is unused.
This was added, but already unused, by commit 70b3740f2c19 ("PCI: endpoint:
Automatically create a function specific attributes group")
Remove it.
Found with cppcheck, unusedStructMember.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
---
drivers/pci/endpoint/pci-ep-cfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index 0ea64e24ed61..ad4e2e329ae9 100644
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -23,7 +23,6 @@ struct pci_epf_group {
struct config_group group;
struct config_group primary_epc_group;
struct config_group secondary_epc_group;
- struct config_group *type_group;
struct delayed_work cfs_work;
struct pci_epf *epf;
int index;
--
2.44.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: endpoint: Remove some unused fields in struct pci_epf_group
2024-04-05 18:16 [PATCH] PCI: endpoint: Remove some unused fields in struct pci_epf_group Christophe JAILLET
@ 2024-05-17 11:08 ` Krzysztof Wilczyński
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Wilczyński @ 2024-05-17 11:08 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Manivannan Sadhasivam, Kishon Vijay Abraham I, Bjorn Helgaas,
linux-kernel, kernel-janitors, linux-pci
Hello,
> In "struct pci_epf_group", the 'type_group' field is unused.
>
> This was added, but already unused, by commit 70b3740f2c19 ("PCI: endpoint:
> Automatically create a function specific attributes group")
>
> Remove it.
>
> Found with cppcheck, unusedStructMember.
Applied to endpoint, thank you!
[1/1] PCI: endpoint: Remove unused field in struct pci_epf_group
https://git.kernel.org/pci/pci/c/ddc66cc4e695
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-17 11:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-05 18:16 [PATCH] PCI: endpoint: Remove some unused fields in struct pci_epf_group Christophe JAILLET
2024-05-17 11:08 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®