[PATCH] KVM: x86: Force KVM_WERROR if the global WERROR is enabled

[PATCH] KVM: x86: Force KVM_WERROR if the global WERROR is enabled

[Sean Christopherson]

Force KVM_WERROR if the global WERROR is enabled to avoid pestering the
user about a Kconfig that will ultimately be ignored.  Force KVM_WERROR
instead of making it mutually exclusive with WERROR to avoid generating a
.config builds KVM with -Werror, but has KVM_WERROR=n.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 arch/x86/kvm/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index 2a7f69abcac3..75082c4a9ac4 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -44,6 +44,7 @@ config KVM
 	select KVM_VFIO
 	select HAVE_KVM_PM_NOTIFIER if PM
 	select KVM_GENERIC_HARDWARE_ENABLING
+	select KVM_WERROR if WERROR
 	help
 	  Support hosting fully virtualized guest machines using hardware
 	  virtualization extensions.  You will need a fairly recent
@@ -66,7 +67,7 @@ config KVM_WERROR
 	# FRAME_WARN, i.e. KVM_WERROR=y with KASAN=y requires special tuning.
 	# Building KVM with -Werror and KASAN is still doable via enabling
 	# the kernel-wide WERROR=y.
-	depends on KVM && EXPERT && !KASAN
+	depends on KVM && ((EXPERT && !KASAN) || WERROR)
 	help
 	  Add -Werror to the build flags for KVM.
 

base-commit: 4aad0b1893a141f114ba40ed509066f3c9bc24b0
-- 
2.45.0.215.g3402c0e53f-goog

Re: [PATCH] KVM: x86: Force KVM_WERROR if the global WERROR is enabled

[Sean Christopherson]

On Fri, 17 May 2024 11:03:41 -0700, Sean Christopherson wrote:
> Force KVM_WERROR if the global WERROR is enabled to avoid pestering the
> user about a Kconfig that will ultimately be ignored.  Force KVM_WERROR
> instead of making it mutually exclusive with WERROR to avoid generating a
> .config builds KVM with -Werror, but has KVM_WERROR=n.
> 
> 

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86: Force KVM_WERROR if the global WERROR is enabled
      https://github.com/kvm-x86/linux/commit/ab28db6b95ed

--
https://github.com/kvm-x86/linux/tree/next