* [PATCH] arm64: dts: qcom: msm8996: add reset for display subsystem
@ 2024-05-25 14:08 Barnabás Czémán
2024-05-25 18:20 ` Markus Elfring
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Barnabás Czémán @ 2024-05-25 14:08 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Barnabás Czémán
Add reset for display subsystem, make sure it gets
properly reset.
Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 8d2cb6f41095..5348feac026e 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -982,6 +982,8 @@ mdss: display-subsystem@900000 {
<&mmcc MDSS_MDP_CLK>;
clock-names = "iface", "core";
+ resets = <&mmcc MDSS_BCR>;
+
#address-cells = <1>;
#size-cells = <1>;
ranges;
---
base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
change-id: 20240525-mdss-reset-8b83eaa24b8c
Best regards,
--
Barnabás Czémán <trabarni@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8996: add reset for display subsystem
2024-05-25 14:08 [PATCH] arm64: dts: qcom: msm8996: add reset for display subsystem Barnabás Czémán
@ 2024-05-25 18:20 ` Markus Elfring
2024-05-25 18:29 ` Krzysztof Kozlowski
2024-05-25 20:03 ` Dmitry Baryshkov
2024-05-27 3:00 ` Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2024-05-25 18:20 UTC (permalink / raw)
To: Barnabás Czémán, devicetree, linux-arm-msm,
kernel-janitors, Bjorn Andersson, Conor Dooley, Konrad Dybcio,
Krzysztof Kozlowski, Rob Herring
Cc: LKML
> Add reset for display subsystem, make sure it gets
> properly reset.
* I suggest to use occasionally more than 50 characters in lines of
such change descriptions.
* Please reconsider word wrapping accordingly.
* Can such information be relevant for the tag “Fixes”?
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8996: add reset for display subsystem
2024-05-25 18:20 ` Markus Elfring
@ 2024-05-25 18:29 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-25 18:29 UTC (permalink / raw)
To: Markus Elfring, Barnabás Czémán, devicetree,
linux-arm-msm, kernel-janitors, Bjorn Andersson, Conor Dooley,
Konrad Dybcio, Rob Herring
Cc: LKML
On 25/05/2024 20:20, Markus Elfring wrote:
>> Add reset for display subsystem, make sure it gets
>> properly reset.
>
> * I suggest to use occasionally more than 50 characters in lines of
> such change descriptions.
>
> * Please reconsider word wrapping accordingly.
>
> * Can such information be relevant for the tag “Fixes”?
<form letter>
Feel free to ignore all comments from Markus, regardless whether the
suggestion is reasonable or not. This person is banned from LKML and
most maintainers ignore Markus' feedback, because it is just a waste of
time.
</form letter>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8996: add reset for display subsystem
2024-05-25 14:08 [PATCH] arm64: dts: qcom: msm8996: add reset for display subsystem Barnabás Czémán
2024-05-25 18:20 ` Markus Elfring
@ 2024-05-25 20:03 ` Dmitry Baryshkov
2024-05-27 3:00 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-05-25 20:03 UTC (permalink / raw)
To: Barnabás Czémán
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Sat, 25 May 2024 at 17:09, Barnabás Czémán <trabarni@gmail.com> wrote:
>
> Add reset for display subsystem, make sure it gets
> properly reset.
>
> Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
[No need to apply any fixes tags, it is not a bug that was present
before and is being fixed, it is an additional functionality]
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8996: add reset for display subsystem
2024-05-25 14:08 [PATCH] arm64: dts: qcom: msm8996: add reset for display subsystem Barnabás Czémán
2024-05-25 18:20 ` Markus Elfring
2024-05-25 20:03 ` Dmitry Baryshkov
@ 2024-05-27 3:00 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2024-05-27 3:00 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Barnabás Czémán
Cc: linux-arm-msm, devicetree, linux-kernel
On Sat, 25 May 2024 16:08:57 +0200, Barnabás Czémán wrote:
> Add reset for display subsystem, make sure it gets
> properly reset.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: msm8996: add reset for display subsystem
commit: b3f8cdef8a5c0bc89ceb1095856f64ba7445c6b9
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-27 3:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-25 14:08 [PATCH] arm64: dts: qcom: msm8996: add reset for display subsystem Barnabás Czémán
2024-05-25 18:20 ` Markus Elfring
2024-05-25 18:29 ` Krzysztof Kozlowski
2024-05-25 20:03 ` Dmitry Baryshkov
2024-05-27 3:00 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®