[PATCH v2] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

[PATCH v2] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

[Shresth Prasad]

Convert txt bindings of ImgTec's PDC watchdog timer to dtschema to allow
for validation.

Signed-off-by: Shresth Prasad <shrestprasad7@gmail.com>
---
Changes in v2:
    - Remove blank space
    - Add item list with description for clocks
    - Drop description for interrupts
    - Drop properties assigned-clocks and assigned-clock-rates
---
 .../bindings/watchdog/img,pdc-wdt.yaml        | 55 +++++++++++++++++++
 .../bindings/watchdog/imgpdc-wdt.txt          | 19 -------
 2 files changed, 55 insertions(+), 19 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/watchdog/img,pdc-wdt.yaml
 delete mode 100644 Documentation/devicetree/bindings/watchdog/imgpdc-wdt.txt

diff --git a/Documentation/devicetree/bindings/watchdog/img,pdc-wdt.yaml b/Documentation/devicetree/bindings/watchdog/img,pdc-wdt.yaml
new file mode 100644
index 000000000000..a88a27354505
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/img,pdc-wdt.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/img,pdc-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ImgTec PowerDown Controller (PDC) Watchdog Timer (WDT)
+
+maintainers:
+  - Shresth Prasad <shresthprasad7@gmail.com>
+
+allOf:
+  - $ref: watchdog.yaml#
+
+properties:
+  compatible:
+    enum:
+      - img,pdc-wdt
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: watchdog counter clock
+      - description: register interface clock
+
+  clock-names:
+    items:
+      - const: wdt
+      - const: sys
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - interrupts
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    watchdog@18102100 {
+      compatible = "img,pdc-wdt";
+      reg = <0x18102100 0x100>;
+      clocks = <&pdc_wdt_clk>, <&sys_clk>;
+      clock-names = "wdt", "sys";
+      interrupts = <0 52 IRQ_TYPE_LEVEL_HIGH>;
+    };
diff --git a/Documentation/devicetree/bindings/watchdog/imgpdc-wdt.txt b/Documentation/devicetree/bindings/watchdog/imgpdc-wdt.txt
deleted file mode 100644
index b2fa11fd43de..000000000000
--- a/Documentation/devicetree/bindings/watchdog/imgpdc-wdt.txt
+++ /dev/null
@@ -1,19 +0,0 @@
-*ImgTec PowerDown Controller (PDC) Watchdog Timer (WDT)
-
-Required properties:
-- compatible : Should be "img,pdc-wdt"
-- reg : Should contain WDT registers location and length
-- clocks: Must contain an entry for each entry in clock-names.
-- clock-names: Should contain "wdt" and "sys"; the watchdog counter
-               clock and register interface clock respectively.
-- interrupts : Should contain WDT interrupt
-
-Examples:
-
-watchdog@18102100 {
-	compatible = "img,pdc-wdt";
-	reg = <0x18102100 0x100>;
-	clocks = <&pdc_wdt_clk>, <&sys_clk>;
-	clock-names = "wdt", "sys";
-	interrupts = <0 52 IRQ_TYPE_LEVEL_HIGH>;
-};
-- 
2.45.1

Re: [PATCH v2] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

[Krzysztof Kozlowski]

On 27/05/2024 21:58, Shresth Prasad wrote:
> Convert txt bindings of ImgTec's PDC watchdog timer to dtschema to allow
> for validation.
> 
> Signed-off-by: Shresth Prasad <shrestprasad7@gmail.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

[Guenter Roeck]

On 5/27/24 12:58, Shresth Prasad wrote:
> Convert txt bindings of ImgTec's PDC watchdog timer to dtschema to allow
> for validation.
> 
> Signed-off-by: Shresth Prasad <shrestprasad7@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH v2] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

[Rob Herring (Arm)]

On Tue, 28 May 2024 01:28:12 +0530, Shresth Prasad wrote:
> Convert txt bindings of ImgTec's PDC watchdog timer to dtschema to allow
> for validation.
> 
> Signed-off-by: Shresth Prasad <shrestprasad7@gmail.com>
> ---
> Changes in v2:
>     - Remove blank space
>     - Add item list with description for clocks
>     - Drop description for interrupts
>     - Drop properties assigned-clocks and assigned-clock-rates
> ---
>  .../bindings/watchdog/img,pdc-wdt.yaml        | 55 +++++++++++++++++++
>  .../bindings/watchdog/imgpdc-wdt.txt          | 19 -------
>  2 files changed, 55 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/img,pdc-wdt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/imgpdc-wdt.txt
> 

Applied, thanks!