From: Prahlad Valluru <quic_vvalluru@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: "Rob Herring (Arm)" <robh@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_nankam@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <quic_abhinavk@quicinc.com>,
<konrad.dybcio@linaro.org>, <conor+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge
Date: Tue, 28 May 2024 19:41:13 +0530 [thread overview]
Message-ID: <20240528141113.GA6631@hu-vvalluru-hyd.qualcomm.com> (raw)
In-Reply-To: <CAA8EJpo=Q4_=JU83-9ooSqiSr=xUeHh2awDhzq9q3Xd56h83zw@mail.gmail.com>
On Wed, May 15, 2024 at 05:28:24PM +0200, Dmitry Baryshkov wrote:
> On Wed, 15 May 2024 at 17:05, Prahlad Valluru <quic_vvalluru@quicinc.com> wrote:
> >
> > On Wed, May 08, 2024 at 09:31:24AM -0500, Rob Herring (Arm) wrote:
> > >
> > > On Mon, 06 May 2024 18:14:10 -0500, Bjorn Andersson wrote:
> > > > On Fri, Apr 26, 2024 at 07:54:42PM GMT, Prahlad Valluru wrote:
> > > > > From: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com>
> > > > >
> > > >
> > > > Please don't thread new versions off existing version. b4 helps you with
> > > > getting these things right, please check go/upstream for more details.
> > > >
> > > > > Enable lt9611uxc bridge for qcs6490 rb3 gen2 platform.
> > > > >
> > > >
> > > > Even if it's clear what this is, I would prefer if you described the
> > > > hardware a little bit in your commit message.
> > > > "Rb3Gen2 has a HDMI connector, connected to DSI via a LT on i2cX.... reset and
> > > > irq pins comes from x and y. Describe this."
> > > >
> > > > > Signed-off-by: Prahlad Valluru <quic_vvalluru@quicinc.com>
> > > > > ---
> > > > > v2: Addressed dtschema errors
> > > > > - Fixed lt9611-irq
> > > > > - vdd-supply error to be ignored, as it is connected to
> > > > > input supply directly, on rb3gen2
> > >
> > > The choice is either fix the dts or fix the binding.
> >
> > vdd-supply is mandatory for lt9611. Only in case of rb3gen2, we are seeing this
> > error, since it is connected to supply directly. Will add dummy vreg to address this.
>
> s/add dummy vreg/describe fixed hardware register/
True, will define a fixed regulator for vdd.
>
>
> --
> With best wishes
> Dmitry
next prev parent reply other threads:[~2024-05-28 14:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 7:13 [PATCH] " Venkata Prahlad Valluru
2024-04-25 14:51 ` Rob Herring
2024-04-26 14:24 ` [PATCH v2] " Prahlad Valluru
2024-05-06 19:54 ` Abhinav Kumar
2024-05-06 23:14 ` Bjorn Andersson
2024-05-07 16:30 ` [PATCH v3] " Venkata Prahlad Valluru
2024-05-07 16:35 ` Krzysztof Kozlowski
2024-05-07 19:20 ` Abhinav Kumar
2024-05-08 7:38 ` Krzysztof Kozlowski
2024-05-08 8:13 ` Dmitry Baryshkov
2024-05-09 8:31 ` Krzysztof Kozlowski
2024-05-08 10:26 ` Prahlad Valluru
2024-05-07 18:43 ` Abhinav Kumar
2024-05-08 10:22 ` [PATCH v2] " Prahlad Valluru
2024-05-08 10:47 ` Dmitry Baryshkov
2024-05-08 14:31 ` Rob Herring (Arm)
2024-05-15 15:04 ` Prahlad Valluru
2024-05-15 15:28 ` Dmitry Baryshkov
2024-05-28 14:11 ` Prahlad Valluru [this message]
2024-05-28 14:19 ` [PATCH v4] " Venkata Prahlad Valluru
2024-05-28 15:00 ` Dmitry Baryshkov
2024-05-28 16:24 ` Prahlad Valluru
2024-05-28 16:33 ` Dmitry Baryshkov
2024-06-27 21:25 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528141113.GA6631@hu-vvalluru-hyd.qualcomm.com \
--to=quic_vvalluru@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_nankam@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®