mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"Venkata Prahlad Valluru" <quic_vvalluru@quicinc.com>,
	<andersson@kernel.org>
Cc: <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
	<konrad.dybcio@linaro.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<quic_nankam@quicinc.com>, <robh@kernel.org>
Subject: Re: [PATCH v3] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge
Date: Tue, 7 May 2024 12:20:30 -0700	[thread overview]
Message-ID: <9a48b0a8-d1d7-8e2d-dafa-47e136a46c99@quicinc.com> (raw)
In-Reply-To: <a32fa81d-bd70-4dfa-b512-e2adce4f8c35@linaro.org>



On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote:
> On 07/05/2024 18:30, Venkata Prahlad Valluru wrote:
>> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with
>> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24.
>> Bridge supplies are Vdd connected to input supply directly
>> and vcc to L11c. Enable HDMI output, bridge and corresponding
>> DSI output.
>>
>> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com>
>> ---
>> v3: - Updated commit text
>>      - Arranged nodes in alphabetical order
>>      - Fixed signoff
>>      - Fixed drive strength for lt9611_irq_pin
>>      - Removed 'label' from hdmi-connector, which is optional
> 
> Please respond to each Bjorn comment and explain how did you implement it...
> 

Yes, agreed. Even though it seems like you mostly just agreed to mine 
and Bjorn's suggestions and decided to implement all those in v3 , it 
would have been better to explicitly ack them or tell why you agreed or 
what went wrong that you had not done it in v2 itself to close the loop.

> Best regards,
> Krzysztof
> 

  reply	other threads:[~2024-05-07 19:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25  7:13 [PATCH] " Venkata Prahlad Valluru
2024-04-25 14:51 ` Rob Herring
2024-04-26 14:24   ` [PATCH v2] " Prahlad Valluru
2024-05-06 19:54     ` Abhinav Kumar
2024-05-06 23:14     ` Bjorn Andersson
2024-05-07 16:30       ` [PATCH v3] " Venkata Prahlad Valluru
2024-05-07 16:35         ` Krzysztof Kozlowski
2024-05-07 19:20           ` Abhinav Kumar [this message]
2024-05-08  7:38             ` Krzysztof Kozlowski
2024-05-08  8:13               ` Dmitry Baryshkov
2024-05-09  8:31                 ` Krzysztof Kozlowski
2024-05-08 10:26               ` Prahlad Valluru
2024-05-07 18:43         ` Abhinav Kumar
2024-05-08 10:22       ` [PATCH v2] " Prahlad Valluru
2024-05-08 10:47         ` Dmitry Baryshkov
2024-05-08 14:31       ` Rob Herring (Arm)
2024-05-15 15:04         ` Prahlad Valluru
2024-05-15 15:28           ` Dmitry Baryshkov
2024-05-28 14:11             ` Prahlad Valluru
2024-05-28 14:19             ` [PATCH v4] " Venkata Prahlad Valluru
2024-05-28 15:00               ` Dmitry Baryshkov
2024-05-28 16:24                 ` Prahlad Valluru
2024-05-28 16:33                   ` Dmitry Baryshkov
2024-06-27 21:25               ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a48b0a8-d1d7-8e2d-dafa-47e136a46c99@quicinc.com \
    --to=quic_abhinavk@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_nankam@quicinc.com \
    --cc=quic_vvalluru@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®