mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ross Philipson <ross.philipson@oracle.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-crypto@vger.kernel.org, kexec@lists.infradead.org,
	linux-efi@vger.kernel.org, iommu@lists.linux-foundation.org
Cc: ross.philipson@oracle.com, dpsmith@apertussolutions.com,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	hpa@zytor.com, dave.hansen@linux.intel.com, ardb@kernel.org,
	mjg59@srcf.ucam.org, James.Bottomley@hansenpartnership.com,
	peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
	luto@amacapital.net, nivedita@alum.mit.edu,
	herbert@gondor.apana.org.au, davem@davemloft.net, corbet@lwn.net,
	ebiederm@xmission.com, dwmw2@infradead.org,
	baolu.lu@linux.intel.com, kanth.ghatraju@oracle.com,
	andrew.cooper3@citrix.com, trenchboot-devel@googlegroups.com
Subject: [PATCH v9 16/19] tpm: Add ability to set the preferred locality the TPM chip uses
Date: Thu, 30 May 2024 18:03:28 -0700	[thread overview]
Message-ID: <20240531010331.134441-17-ross.philipson@oracle.com> (raw)
In-Reply-To: <20240531010331.134441-1-ross.philipson@oracle.com>

Curently the locality is hard coded to 0 but for DRTM support, access
is needed to localities 1 through 4.

Signed-off-by: Ross Philipson <ross.philipson@oracle.com>
---
 drivers/char/tpm/tpm-chip.c      | 24 +++++++++++++++++++++++-
 drivers/char/tpm/tpm-interface.c | 15 +++++++++++++++
 drivers/char/tpm/tpm.h           |  1 +
 include/linux/tpm.h              |  4 ++++
 4 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
index 854546000c92..73eac54d61fb 100644
--- a/drivers/char/tpm/tpm-chip.c
+++ b/drivers/char/tpm/tpm-chip.c
@@ -44,7 +44,7 @@ static int tpm_request_locality(struct tpm_chip *chip)
 	if (!chip->ops->request_locality)
 		return 0;
 
-	rc = chip->ops->request_locality(chip, 0);
+	rc = chip->ops->request_locality(chip, chip->pref_locality);
 	if (rc < 0)
 		return rc;
 
@@ -143,6 +143,27 @@ void tpm_chip_stop(struct tpm_chip *chip)
 }
 EXPORT_SYMBOL_GPL(tpm_chip_stop);
 
+/**
+ * tpm_chip_preferred_locality() - set the TPM chip preferred locality to open
+ * @chip:	a TPM chip to use
+ * @locality:   the preferred locality
+ *
+ * Return:
+ * * true      - Preferred locality set
+ * * false     - Invalid locality specified
+ */
+bool tpm_chip_preferred_locality(struct tpm_chip *chip, int locality)
+{
+	if (locality < 0 || locality >=TPM_MAX_LOCALITY)
+		return false;
+
+	mutex_lock(&chip->tpm_mutex);
+	chip->pref_locality = locality;
+	mutex_unlock(&chip->tpm_mutex);
+	return true;
+}
+EXPORT_SYMBOL_GPL(tpm_chip_preferred_locality);
+
 /**
  * tpm_try_get_ops() - Get a ref to the tpm_chip
  * @chip: Chip to ref
@@ -374,6 +395,7 @@ struct tpm_chip *tpm_chip_alloc(struct device *pdev,
 	}
 
 	chip->locality = -1;
+	chip->pref_locality = 0;
 	return chip;
 
 out:
diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index 5da134f12c9a..35f14ccecf0e 100644
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -274,6 +274,21 @@ int tpm_is_tpm2(struct tpm_chip *chip)
 }
 EXPORT_SYMBOL_GPL(tpm_is_tpm2);
 
+/**
+ * tpm_preferred_locality() - set the TPM chip preferred locality to open
+ * @chip:	a TPM chip to use
+ * @locality:   the preferred locality
+ *
+ * Return:
+ * * true      - Preferred locality set
+ * * false     - Invalid locality specified
+ */
+bool tpm_preferred_locality(struct tpm_chip *chip, int locality)
+{
+	return tpm_chip_preferred_locality(chip, locality);
+}
+EXPORT_SYMBOL_GPL(tpm_preferred_locality);
+
 /**
  * tpm_pcr_read - read a PCR value from SHA1 bank
  * @chip:	a &struct tpm_chip instance, %NULL for the default chip
diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
index 6b8b9956ba69..be465422d3fa 100644
--- a/drivers/char/tpm/tpm.h
+++ b/drivers/char/tpm/tpm.h
@@ -267,6 +267,7 @@ static inline void tpm_msleep(unsigned int delay_msec)
 int tpm_chip_bootstrap(struct tpm_chip *chip);
 int tpm_chip_start(struct tpm_chip *chip);
 void tpm_chip_stop(struct tpm_chip *chip);
+bool tpm_chip_preferred_locality(struct tpm_chip *chip, int locality);
 struct tpm_chip *tpm_find_get_ops(struct tpm_chip *chip);
 
 struct tpm_chip *tpm_chip_alloc(struct device *dev,
diff --git a/include/linux/tpm.h b/include/linux/tpm.h
index 363f7078c3a9..935a3457d7c8 100644
--- a/include/linux/tpm.h
+++ b/include/linux/tpm.h
@@ -219,6 +219,9 @@ struct tpm_chip {
 	u8 null_ec_key_y[EC_PT_SZ];
 	struct tpm2_auth *auth;
 #endif
+
+	/* preferred locality - default 0 */
+	int pref_locality;
 };
 
 #define TPM_HEADER_SIZE		10
@@ -461,6 +464,7 @@ static inline u32 tpm2_rc_value(u32 rc)
 #if defined(CONFIG_TCG_TPM) || defined(CONFIG_TCG_TPM_MODULE)
 
 extern int tpm_is_tpm2(struct tpm_chip *chip);
+extern bool tpm_preferred_locality(struct tpm_chip *chip, int locality);
 extern __must_check int tpm_try_get_ops(struct tpm_chip *chip);
 extern void tpm_put_ops(struct tpm_chip *chip);
 extern ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_buf *buf,
-- 
2.39.3


  parent reply	other threads:[~2024-05-31  1:33 UTC|newest]

Thread overview: 116+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31  1:03 [PATCH v9 00/19] x86: Trenchboot secure dynamic launch Linux kernel support Ross Philipson
2024-05-31  1:03 ` [PATCH v9 01/19] x86/boot: Place kernel_info at a fixed offset Ross Philipson
2024-06-04 18:18   ` Jarkko Sakkinen
2024-06-04 20:28     ` ross.philipson
2024-05-31  1:03 ` [PATCH v9 02/19] Documentation/x86: Secure Launch kernel documentation Ross Philipson
2024-05-31  1:03 ` [PATCH v9 03/19] x86: Secure Launch Kconfig Ross Philipson
2024-05-31  1:03 ` [PATCH v9 04/19] x86: Secure Launch Resource Table header file Ross Philipson
2024-06-04 18:21   ` Jarkko Sakkinen
2024-06-04 20:31     ` ross.philipson
2024-06-04 22:36       ` Jarkko Sakkinen
2024-06-04 23:00         ` ross.philipson
2024-06-05  0:22           ` Jarkko Sakkinen
2024-06-05  0:27             ` Jarkko Sakkinen
2024-06-05  2:33             ` ross.philipson
2024-06-05  4:04               ` Jarkko Sakkinen
2024-06-05 19:03                 ` ross.philipson
2024-06-06  6:02                   ` Jarkko Sakkinen
2024-06-06 16:49                     ` ross.philipson
2024-06-20  0:18                       ` Jarkko Sakkinen
2024-06-20 16:55                         ` ross.philipson
2024-05-31  1:03 ` [PATCH v9 05/19] x86: Secure Launch main " Ross Philipson
2024-06-04 18:24   ` Jarkko Sakkinen
2024-06-04 20:52     ` ross.philipson
2024-05-31  1:03 ` [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements Ross Philipson
2024-05-31  2:16   ` Eric Biggers
2024-05-31 13:54     ` Eric W. Biederman
2024-08-15 17:38       ` Daniel P. Smith
2024-08-15 19:10         ` Thomas Gleixner
2024-08-16 10:42           ` Jarkko Sakkinen
2024-08-16 11:01           ` Andrew Cooper
2024-08-16 11:22             ` Jarkko Sakkinen
2024-08-16 18:41               ` Matthew Garrett
2024-08-19 18:05                 ` Jarkko Sakkinen
2024-08-19 18:24                   ` Matthew Garrett
2024-08-20 15:26                     ` Jarkko Sakkinen
2024-08-22 18:29           ` Daniel P. Smith
2026-02-20 15:35             ` Ard Biesheuvel
2026-02-23 23:08               ` Andrew Cooper
2026-02-24  8:25                 ` Ard Biesheuvel
2024-08-29  3:17           ` Andy Lutomirski
2024-08-29  3:25             ` Matthew Garrett
2024-08-29 17:26               ` Andy Lutomirski
2024-09-05  1:01             ` Daniel P. Smith
2024-09-13  0:34               ` Daniel P. Smith
2024-09-14  3:57                 ` Andy Lutomirski
2024-09-21 18:36                   ` Daniel P. Smith
2024-09-21 22:40                     ` Andy Lutomirski
2024-11-02 14:53                       ` Daniel P. Smith
2024-11-02 16:04                         ` James Bottomley
2024-11-15  1:17                           ` Daniel P. Smith
2024-11-18 18:43                             ` Andy Lutomirski
2024-11-18 18:50                               ` Andy Lutomirski
2024-11-18 19:12                               ` James Bottomley
2024-11-18 20:02                                 ` Andy Lutomirski
2024-11-21 20:11                                   ` ross.philipson
2024-11-21 20:54                                     ` Andy Lutomirski
2024-11-21 22:42                                       ` Andy Lutomirski
2024-11-22 23:37                                         ` ross.philipson
2024-12-12 19:56                                   ` Daniel P. Smith
2024-12-12 22:30                                     ` Andy Lutomirski
2024-12-14  2:56                                       ` Daniel P. Smith
2024-05-31 16:18     ` ross.philipson
2024-08-27 18:14     ` Eric Biggers
2024-08-28 20:14       ` ross.philipson
2024-08-28 23:13         ` Eric Biggers
2024-06-04 18:52   ` Jarkko Sakkinen
2024-06-04 21:02     ` ross.philipson
2024-06-04 22:40       ` Jarkko Sakkinen
2024-05-31  1:03 ` [PATCH v9 07/19] x86: Add early SHA-256 " Ross Philipson
2024-05-31  1:03 ` [PATCH v9 08/19] x86: Secure Launch kernel early boot stub Ross Philipson
2024-05-31 11:00   ` Ard Biesheuvel
2024-05-31 13:33     ` Ard Biesheuvel
2024-05-31 14:04       ` Ard Biesheuvel
2024-05-31 16:13         ` Ard Biesheuvel
2024-06-04 17:31         ` ross.philipson
2024-06-04 17:24       ` ross.philipson
2024-06-04 17:27         ` Ard Biesheuvel
2024-06-04 17:33           ` ross.philipson
2024-06-04 20:54             ` Ard Biesheuvel
2024-06-04 21:12               ` ross.philipson
2024-06-04 17:14     ` ross.philipson
2024-06-04 19:56   ` Jarkko Sakkinen
2024-06-04 21:09     ` ross.philipson
2024-06-04 22:43       ` Jarkko Sakkinen
2024-05-31  1:03 ` [PATCH v9 09/19] x86: Secure Launch kernel late " Ross Philipson
2024-06-04 19:58   ` Jarkko Sakkinen
2024-06-04 21:16     ` ross.philipson
2024-06-04 22:45       ` Jarkko Sakkinen
2024-06-04 19:59   ` Jarkko Sakkinen
2024-06-04 21:17     ` ross.philipson
2024-08-12 19:02     ` ross.philipson
2024-08-15 18:35       ` Jarkko Sakkinen
2024-05-31  1:03 ` [PATCH v9 10/19] x86: Secure Launch SMP bringup support Ross Philipson
2024-06-04 20:05   ` Jarkko Sakkinen
2024-06-04 21:47     ` ross.philipson
2024-06-04 22:46       ` Jarkko Sakkinen
2024-05-31  1:03 ` [PATCH v9 11/19] kexec: Secure Launch kexec SEXIT support Ross Philipson
2024-05-31  1:03 ` [PATCH v9 12/19] reboot: Secure Launch SEXIT support on reboot paths Ross Philipson
2024-05-31  1:03 ` [PATCH v9 13/19] tpm: Protect against locality counter underflow Ross Philipson
2024-06-04 20:12   ` Jarkko Sakkinen
2024-08-15 18:52     ` Daniel P. Smith
2024-05-31  1:03 ` [PATCH v9 14/19] tpm: Ensure tpm is in known state at startup Ross Philipson
2024-06-04 20:14   ` Jarkko Sakkinen
2024-08-15 19:24     ` Daniel P. Smith
2024-05-31  1:03 ` [PATCH v9 15/19] tpm: Make locality requests return consistent values Ross Philipson
2024-05-31  1:03 ` Ross Philipson [this message]
2024-06-04 20:27   ` [PATCH v9 16/19] tpm: Add ability to set the preferred locality the TPM chip uses Jarkko Sakkinen
2024-06-04 22:14     ` ross.philipson
2024-06-04 22:50       ` Jarkko Sakkinen
2024-06-04 23:04         ` ross.philipson
2024-05-31  1:03 ` [PATCH v9 17/19] tpm: Add sysfs interface to allow setting and querying the preferred locality Ross Philipson
2024-06-04 20:27   ` Jarkko Sakkinen
2024-05-31  1:03 ` [PATCH v9 18/19] x86: Secure Launch late initcall platform module Ross Philipson
2024-05-31  1:03 ` [PATCH v9 19/19] x86: EFI stub DRTM launch support for Secure Launch Ross Philipson
2024-05-31 11:09   ` Ard Biesheuvel
2024-06-04 17:22     ` ross.philipson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240531010331.134441-17-ross.philipson@oracle.com \
    --to=ross.philipson@oracle.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ardb@kernel.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=dpsmith@apertussolutions.com \
    --cc=dwmw2@infradead.org \
    --cc=ebiederm@xmission.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=hpa@zytor.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kanth.ghatraju@oracle.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=nivedita@alum.mit.edu \
    --cc=peterhuewe@gmx.de \
    --cc=tglx@linutronix.de \
    --cc=trenchboot-devel@googlegroups.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®