From: Chia-I Wu <olvaffe@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
Baoquan He <bhe@redhat.com>,
Alison Schofield <alison.schofield@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] resource: add a basic test for walk_iomem_res_desc
Date: Tue, 4 Jun 2024 14:31:46 -0700 [thread overview]
Message-ID: <20240604213200.672279-1-olvaffe@gmail.com> (raw)
This mainly tests that find_next_iomem_res() does not miss resources.
Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
---
kernel/resource_kunit.c | 96 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 96 insertions(+)
diff --git a/kernel/resource_kunit.c b/kernel/resource_kunit.c
index 58ab9f914602b..1cbeeb44d0822 100644
--- a/kernel/resource_kunit.c
+++ b/kernel/resource_kunit.c
@@ -6,6 +6,7 @@
#include <kunit/test.h>
#include <linux/ioport.h>
#include <linux/kernel.h>
+#include <linux/sizes.h>
#include <linux/string.h>
#define R0_START 0x0000
@@ -137,9 +138,104 @@ static void resource_test_intersection(struct kunit *test)
} while (++i < ARRAY_SIZE(results_for_intersection));
}
+static int resource_walk_count(struct resource *res, void *data)
+{
+ int *count = data;
+ (*count)++;
+ return 0;
+}
+
+static void resource_test_walk_iomem_res_desc(struct kunit *test)
+{
+ struct resource root = {
+ .name = "Resource Walk Test",
+ };
+ struct resource res[8];
+ resource_size_t offset;
+ int count;
+
+ KUNIT_ASSERT_EQ(test, 0,
+ allocate_resource(&iomem_resource, &root, SZ_1M,
+ 0, ~0, SZ_1M, NULL, NULL));
+
+ /* build the resource tree */
+ offset = root.start;
+ res[0] = (struct resource){
+ .start = offset,
+ .end = offset + SZ_1K - 1,
+ .name = "SYSRAM 1",
+ .flags = IORESOURCE_SYSTEM_RAM,
+ };
+ offset += SZ_1K;
+
+ res[1] = (struct resource){
+ .start = offset,
+ .end = offset + SZ_1K - 1,
+ .name = "OTHER",
+ };
+ offset += SZ_1K;
+
+ /* hole */
+ offset += SZ_1K;
+
+ res[2] = (struct resource){
+ .start = offset,
+ .end = offset + SZ_1K - 1,
+ .name = "NESTED",
+ };
+ res[3] = (struct resource){
+ .start = offset + SZ_512,
+ .end = offset + SZ_1K - 1,
+ .name = "SYSRAM 2",
+ .flags = IORESOURCE_SYSTEM_RAM,
+ };
+ offset += SZ_1K;
+
+ res[4] = (struct resource){
+ .start = offset,
+ .end = offset + SZ_1K - 1,
+ .name = "SYSRAM 3",
+ .flags = IORESOURCE_SYSTEM_RAM,
+ };
+ offset += SZ_1K;
+
+ KUNIT_EXPECT_EQ(test, 0, request_resource(&root, &res[0]));
+ KUNIT_EXPECT_EQ(test, 0, request_resource(&root, &res[1]));
+ KUNIT_EXPECT_EQ(test, 0, request_resource(&root, &res[2]));
+ KUNIT_EXPECT_EQ(test, 0, request_resource(&res[2], &res[3]));
+ KUNIT_EXPECT_EQ(test, 0, request_resource(&root, &res[4]));
+
+ /* walk the entire region */
+ count = 0;
+ walk_iomem_res_desc(IORES_DESC_NONE, IORESOURCE_SYSTEM_RAM,
+ root.start, root.end, &count, resource_walk_count);
+ KUNIT_EXPECT_EQ(test, count, 3);
+
+ /* walk the region requested by res[1] */
+ count = 0;
+ walk_iomem_res_desc(IORES_DESC_NONE, IORESOURCE_SYSTEM_RAM,
+ res[1].start, res[1].end, &count, resource_walk_count);
+ KUNIT_EXPECT_EQ(test, count, 0);
+
+ /* walk the region requested by res[2] */
+ count = 0;
+ walk_iomem_res_desc(IORES_DESC_NONE, IORESOURCE_SYSTEM_RAM,
+ res[2].start, res[2].end, &count, resource_walk_count);
+ KUNIT_EXPECT_EQ(test, count, 1);
+
+ /* walk the region requested by res[4] */
+ count = 0;
+ walk_iomem_res_desc(IORES_DESC_NONE, IORESOURCE_SYSTEM_RAM,
+ res[4].start, res[4].end, &count, resource_walk_count);
+ KUNIT_EXPECT_EQ(test, count, 1);
+
+ release_resource(&root);
+}
+
static struct kunit_case resource_test_cases[] = {
KUNIT_CASE(resource_test_union),
KUNIT_CASE(resource_test_intersection),
+ KUNIT_CASE(resource_test_walk_iomem_res_desc),
{}
};
--
2.45.1.288.g0e0cd299f1-goog
next reply other threads:[~2024-06-04 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 21:31 Chia-I Wu [this message]
2024-06-04 21:38 ` Andy Shevchenko
2024-06-04 21:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604213200.672279-1-olvaffe@gmail.com \
--to=olvaffe@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=takahiro.akashi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®