From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Chia-I Wu <olvaffe@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
Baoquan He <bhe@redhat.com>,
Alison Schofield <alison.schofield@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] resource: add a basic test for walk_iomem_res_desc
Date: Wed, 5 Jun 2024 00:45:58 +0300 [thread overview]
Message-ID: <Zl-LFtGP3z4rR-7S@smile.fi.intel.com> (raw)
In-Reply-To: <Zl-JUkLoxqraKciw@smile.fi.intel.com>
On Wed, Jun 05, 2024 at 12:38:27AM +0300, Andy Shevchenko wrote:
> On Tue, Jun 04, 2024 at 02:31:46PM -0700, Chia-I Wu wrote:
...
> > + res[2] = (struct resource){
> > + .start = offset,
> > + .end = offset + SZ_1K - 1,
> > + .name = "NESTED",
> > + };
>
> We have respective macros. Use them.
And use explicitly hardocded start in all of them instead of coding += for
offset variable. For the test cases is better when data is hardcoded, esp.
when it's an expected result (just to mention, here it seems an input data).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-06-04 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 21:31 Chia-I Wu
2024-06-04 21:38 ` Andy Shevchenko
2024-06-04 21:45 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl-LFtGP3z4rR-7S@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olvaffe@gmail.com \
--cc=takahiro.akashi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®