* [PATCH] bcache: Fix compiler warnings
@ 2024-06-05 3:40 Marilene A Garcia
2024-06-05 22:27 ` Marilene Andrade Garcia
0 siblings, 1 reply; 2+ messages in thread
From: Marilene A Garcia @ 2024-06-05 3:40 UTC (permalink / raw)
To: Coly Li, Kent Overstreet
Cc: Marilene A Garcia, Shuah Khan, Javier Carrasco, linux-bcache,
linux-kernel
It fixes the following compiler warnings by
using "/*" instead of "/**" in the comments
drivers/md/bcache/request.c:309: warning:
Function parameter or struct member 'bch_data_insert'
not described in 'CLOSURE_CALLBACK'
drivers/md/bcache/request.c:309: warning: expecting
prototype for bch_data_insert(). Prototype was for
CLOSURE_CALLBACK() instead
Signed-off-by: Marilene A Garcia <marilene.agarcia@gmail.com>
---
Hello,
These warnings happen using GCC compiler the command 'make W=1'.
Thank you.
drivers/md/bcache/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index af345dc6fde1..457b9605aff9 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -285,7 +285,7 @@ static CLOSURE_CALLBACK(bch_data_insert_start)
}
}
-/**
+/*
* bch_data_insert - stick some data in the cache
* @cl: closure pointer.
*
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bcache: Fix compiler warnings
2024-06-05 3:40 [PATCH] bcache: Fix compiler warnings Marilene A Garcia
@ 2024-06-05 22:27 ` Marilene Andrade Garcia
0 siblings, 0 replies; 2+ messages in thread
From: Marilene Andrade Garcia @ 2024-06-05 22:27 UTC (permalink / raw)
To: Coly Li, Kent Overstreet
Cc: Shuah Khan, Javier Carrasco, linux-bcache, linux-kernel
On 05/06/2024 00:40, Marilene A Garcia wrote:
> It fixes the following compiler warnings by
> using "/*" instead of "/**" in the comments
>
> drivers/md/bcache/request.c:309: warning:
> Function parameter or struct member 'bch_data_insert'
> not described in 'CLOSURE_CALLBACK'
>
> drivers/md/bcache/request.c:309: warning: expecting
> prototype for bch_data_insert(). Prototype was for
> CLOSURE_CALLBACK() instead
>
> Signed-off-by: Marilene A Garcia <marilene.agarcia@gmail.com>
> ---
> Hello,
> These warnings happen using GCC compiler the command 'make W=1'.
>
> Thank you.
>
> drivers/md/bcache/request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index af345dc6fde1..457b9605aff9 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -285,7 +285,7 @@ static CLOSURE_CALLBACK(bch_data_insert_start)
> }
> }
>
> -/**
> +/*
> * bch_data_insert - stick some data in the cache
> * @cl: closure pointer.
> *
Hello,
I have realized that even though this change could fix the warning, it
is not the correct fix to it, because it breaks the format of kernel
function comments.
So please discard the patch.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-05 22:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-05 3:40 [PATCH] bcache: Fix compiler warnings Marilene A Garcia
2024-06-05 22:27 ` Marilene Andrade Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®