[PATCH v2] arm64: dts: mediatek: mt8195: Add SCP phandle to MDP3 DMA controller

[PATCH v2] arm64: dts: mediatek: mt8195: Add SCP phandle to MDP3 DMA controller

[Nícolas F. R. A. Prado]

While the MDP3 DMA controller can look for the SCP node based on
compatible, it's best practice to supply the MDP3 node with a phandle to
the SCP since that allows supporting dual core SCP as well. Besides,
relying on the compatible search causes an error to be printed, since
the phandle is tried first:

  mtk-mdp3 14001000.dma-controller: can't get SCP node

Add the missing phandle to follow the best practice and get rid of the
error.

Fixes: 5710462a116c ("arm64: dts: mediatek: mt8195: add MDP3 nodes")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Changes in v2:
- Added scp phandle property in DT instead of removing the error message
- Link to v1: https://lore.kernel.org/r/20240605-mt8195-dma-scp-node-err-v1-1-f2cb42f24d6e@collabora.com
---
 arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index 2ee45752583c..a46062258603 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -2037,6 +2037,7 @@ dma-controller@14001000 {
 			mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x1000 0x1000>;
 			mediatek,gce-events = <CMDQ_EVENT_VPP0_MDP_RDMA_SOF>,
 					      <CMDQ_EVENT_VPP0_MDP_RDMA_FRAME_DONE>;
+			mediatek,scp = <&scp>;
 			power-domains = <&spm MT8195_POWER_DOMAIN_VPPSYS0>;
 			iommus = <&iommu_vpp M4U_PORT_L4_MDP_RDMA>;
 			clocks = <&vppsys0 CLK_VPP0_MDP_RDMA>;

---
base-commit: d97496ca23a2d4ee80b7302849404859d9058bcd
change-id: 20240605-mt8195-dma-scp-node-err-6a8dea26d4f5

Best regards,
-- 
Nícolas F. R. A. Prado <nfraprado@collabora.com>

Re: [PATCH v2] arm64: dts: mediatek: mt8195: Add SCP phandle to MDP3 DMA controller

[Nícolas F. R. A. Prado]

On Thu, Jun 06, 2024 at 05:12:04PM -0400, Nícolas F. R. A. Prado wrote:
> While the MDP3 DMA controller can look for the SCP node based on
> compatible, it's best practice to supply the MDP3 node with a phandle to
> the SCP since that allows supporting dual core SCP as well. Besides,
> relying on the compatible search causes an error to be printed, since
> the phandle is tried first:
> 
>   mtk-mdp3 14001000.dma-controller: can't get SCP node
> 
> Add the missing phandle to follow the best practice and get rid of the
> error.
> 
> Fixes: 5710462a116c ("arm64: dts: mediatek: mt8195: add MDP3 nodes")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Hi Angelo,

I already asked in another patch, but in case that was missed: It seems this
patch was missed. Do you want me to resend it?

Thanks,
Nícolas

Re: [PATCH v2] arm64: dts: mediatek: mt8195: Add SCP phandle to MDP3 DMA controller

[AngeloGioacchino Del Regno]

On Thu, 06 Jun 2024 17:12:04 -0400, Nícolas F. R. A. Prado wrote:
> While the MDP3 DMA controller can look for the SCP node based on
> compatible, it's best practice to supply the MDP3 node with a phandle to
> the SCP since that allows supporting dual core SCP as well. Besides,
> relying on the compatible search causes an error to be printed, since
> the phandle is tried first:
> 
>   mtk-mdp3 14001000.dma-controller: can't get SCP node
> 
> [...]

Applied to v6.11-next/dts64, thanks!

[1/1] arm64: dts: mediatek: mt8195: Add SCP phandle to MDP3 DMA controller
      commit: 587c945c933364f24d132918d7703997fd1e2cd6

Cheers,
Angelo