* [PATCH] cpufreq: ti-cpufreq: Handle deferred probe with dev_err_probe()
@ 2024-06-06 6:58 Primoz Fiser
2024-06-06 9:00 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Primoz Fiser @ 2024-06-06 6:58 UTC (permalink / raw)
To: Rafael J . Wysocki, Viresh Kumar, linux-pm, linux-kernel; +Cc: upstream
Handle deferred probing gracefully by using dev_err_probe() to not
spam console with unnecessary error messages.
Fixes: f88d152dc739 ("cpufreq: ti: Migrate to dev_pm_opp_set_config()")
Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
drivers/cpufreq/ti-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
index 714ed53753fa..5af85c4cbad0 100644
--- a/drivers/cpufreq/ti-cpufreq.c
+++ b/drivers/cpufreq/ti-cpufreq.c
@@ -417,7 +417,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev)
ret = dev_pm_opp_set_config(opp_data->cpu_dev, &config);
if (ret < 0) {
- dev_err(opp_data->cpu_dev, "Failed to set OPP config\n");
+ dev_err_probe(opp_data->cpu_dev, ret, "Failed to set OPP config\n");
goto fail_put_node;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: ti-cpufreq: Handle deferred probe with dev_err_probe()
2024-06-06 6:58 [PATCH] cpufreq: ti-cpufreq: Handle deferred probe with dev_err_probe() Primoz Fiser
@ 2024-06-06 9:00 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2024-06-06 9:00 UTC (permalink / raw)
To: Primoz Fiser; +Cc: Rafael J . Wysocki, linux-pm, linux-kernel, upstream
On 06-06-24, 08:58, Primoz Fiser wrote:
> Handle deferred probing gracefully by using dev_err_probe() to not
> spam console with unnecessary error messages.
>
> Fixes: f88d152dc739 ("cpufreq: ti: Migrate to dev_pm_opp_set_config()")
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> ---
> drivers/cpufreq/ti-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
> index 714ed53753fa..5af85c4cbad0 100644
> --- a/drivers/cpufreq/ti-cpufreq.c
> +++ b/drivers/cpufreq/ti-cpufreq.c
> @@ -417,7 +417,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev)
>
> ret = dev_pm_opp_set_config(opp_data->cpu_dev, &config);
> if (ret < 0) {
> - dev_err(opp_data->cpu_dev, "Failed to set OPP config\n");
> + dev_err_probe(opp_data->cpu_dev, ret, "Failed to set OPP config\n");
> goto fail_put_node;
> }
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-06 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-06 6:58 [PATCH] cpufreq: ti-cpufreq: Handle deferred probe with dev_err_probe() Primoz Fiser
2024-06-06 9:00 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®