mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] cpufreq: intel_pstate: Update Meteor Lake EPPs
@ 2024-06-06 18:12 Srinivas Pandruvada
  2024-06-07 19:08 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Pandruvada @ 2024-06-06 18:12 UTC (permalink / raw)
  To: rafael, viresh.kumar; +Cc: linux-pm, linux-kernel, Srinivas Pandruvada

Update the default balance_performance EPP to 64. This gives better
performance and also perf/watt compared to current value of 115.

For example:

Speedometer 2.1
	score: +19%
	Perf/watt: +5.25%

Webxprt 4 score
	score: +12%
	Perf/watt: +6.12%

3DMark Wildlife extreme unlimited score
	score: +3.2%
	Perf/watt: +11.5%

Geekbench6 MT
	score: +2.14%
	Perf/watt: +0.32%

Also update balance_power EPP default to 179. With this change:
	Video Playback power is reduced by 52%
	Team video conference power is reduced by 35%

With Power profile daemon now sets balance_power EPP on DC instead of
balance_performance, updating balance_power EPP will help to extend
battery life.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/cpufreq/intel_pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index dbbf299f4219..8b0032d6a519 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -3429,7 +3429,7 @@ static const struct x86_cpu_id intel_epp_default[] = {
 	X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, HWP_SET_DEF_BALANCE_PERF_EPP(102)),
 	X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, HWP_SET_DEF_BALANCE_PERF_EPP(32)),
 	X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE_L, HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,
-							HWP_EPP_BALANCE_POWERSAVE, 115, 16)),
+								    179, 64, 16)),
 	{}
 };
 
-- 
2.44.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] cpufreq: intel_pstate: Update Meteor Lake EPPs
  2024-06-06 18:12 [PATCH] cpufreq: intel_pstate: Update Meteor Lake EPPs Srinivas Pandruvada
@ 2024-06-07 19:08 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2024-06-07 19:08 UTC (permalink / raw)
  To: Srinivas Pandruvada; +Cc: rafael, viresh.kumar, linux-pm, linux-kernel

On Thu, Jun 6, 2024 at 8:12 PM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
>
> Update the default balance_performance EPP to 64. This gives better
> performance and also perf/watt compared to current value of 115.
>
> For example:
>
> Speedometer 2.1
>         score: +19%
>         Perf/watt: +5.25%
>
> Webxprt 4 score
>         score: +12%
>         Perf/watt: +6.12%
>
> 3DMark Wildlife extreme unlimited score
>         score: +3.2%
>         Perf/watt: +11.5%
>
> Geekbench6 MT
>         score: +2.14%
>         Perf/watt: +0.32%
>
> Also update balance_power EPP default to 179. With this change:
>         Video Playback power is reduced by 52%
>         Team video conference power is reduced by 35%
>
> With Power profile daemon now sets balance_power EPP on DC instead of
> balance_performance, updating balance_power EPP will help to extend
> battery life.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index dbbf299f4219..8b0032d6a519 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -3429,7 +3429,7 @@ static const struct x86_cpu_id intel_epp_default[] = {
>         X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, HWP_SET_DEF_BALANCE_PERF_EPP(102)),
>         X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, HWP_SET_DEF_BALANCE_PERF_EPP(32)),
>         X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE_L, HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,
> -                                                       HWP_EPP_BALANCE_POWERSAVE, 115, 16)),
> +                                                                   179, 64, 16)),
>         {}
>  };
>
> --

Rebased on top of the Tony's series:

https://lore.kernel.org/linux-acpi/20240528184720.56259-1-tony.luck@intel.com/

and applied as 6.11 material.

Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-07 19:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-06 18:12 [PATCH] cpufreq: intel_pstate: Update Meteor Lake EPPs Srinivas Pandruvada
2024-06-07 19:08 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®