* [PATCH] modpost: do not warn about missing MODULE_DESCRIPTION() for vmlinux.o
@ 2024-06-06 18:36 Masahiro Yamada
2024-06-06 19:40 ` Vincenzo Palazzo
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2024-06-06 18:36 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, Masahiro Yamada, Nathan Chancellor, Nicolas Schier,
Vincenzo Palazzo
Building with W=1 incorrectly emits the following warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o
This check should apply only to modules.
Fixes: 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
scripts/mod/modpost.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 937294ff164f..f48d72d22dc2 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname)
namespace = get_next_modinfo(&info, "import_ns",
namespace);
}
+
+ if (extra_warn && !get_modinfo(&info, "description"))
+ warn("missing MODULE_DESCRIPTION() in %s\n", modname);
}
- if (extra_warn && !get_modinfo(&info, "description"))
- warn("missing MODULE_DESCRIPTION() in %s\n", modname);
for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
symname = remove_dot(info.strtab + sym->st_name);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] modpost: do not warn about missing MODULE_DESCRIPTION() for vmlinux.o
2024-06-06 18:36 [PATCH] modpost: do not warn about missing MODULE_DESCRIPTION() for vmlinux.o Masahiro Yamada
@ 2024-06-06 19:40 ` Vincenzo Palazzo
0 siblings, 0 replies; 2+ messages in thread
From: Vincenzo Palazzo @ 2024-06-06 19:40 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, linux-kernel, Nathan Chancellor, Nicolas Schier
LGMT, thanks
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
On Thu, Jun 6, 2024 at 8:39 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Building with W=1 incorrectly emits the following warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o
>
> This check should apply only to modules.
>
> Fixes: 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing")
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/mod/modpost.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 937294ff164f..f48d72d22dc2 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname)
> namespace = get_next_modinfo(&info, "import_ns",
> namespace);
> }
> +
> + if (extra_warn && !get_modinfo(&info, "description"))
> + warn("missing MODULE_DESCRIPTION() in %s\n", modname);
> }
>
> - if (extra_warn && !get_modinfo(&info, "description"))
> - warn("missing MODULE_DESCRIPTION() in %s\n", modname);
> for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
> symname = remove_dot(info.strtab + sym->st_name);
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-06 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-06 18:36 [PATCH] modpost: do not warn about missing MODULE_DESCRIPTION() for vmlinux.o Masahiro Yamada
2024-06-06 19:40 ` Vincenzo Palazzo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®