From: Armin Wolf <W_Armin@gmx.de>
To: matan@svgalib.org, agathe@boutmy.com
Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] platform/x86: lg-laptop: Remove LGEX0815 hotkey handling
Date: Fri, 7 Jun 2024 01:35:38 +0200 [thread overview]
Message-ID: <20240606233540.9774-3-W_Armin@gmx.de> (raw)
In-Reply-To: <20240606233540.9774-1-W_Armin@gmx.de>
The rfkill hotkey handling is already provided by the wireless-hotkey
driver. Remove the now unnecessary rfkill hotkey handling to avoid
duplicating functionality.
The ACPI notify handler still prints debugging information when
receiving ACPI notifications to aid in reverse-engineering.
Tested-by: Agathe Boutmy <agathe@boutmy.com>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
drivers/platform/x86/lg-laptop.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
index d0fee5d375d7..ea83630106e8 100644
--- a/drivers/platform/x86/lg-laptop.c
+++ b/drivers/platform/x86/lg-laptop.c
@@ -84,7 +84,6 @@ static const struct key_entry wmi_keymap[] = {
* this key both sends an event and
* changes backlight level.
*/
- {KE_KEY, 0x80, {KEY_RFKILL} },
{KE_END, 0}
};
@@ -272,14 +271,7 @@ static void wmi_input_setup(void)
static void acpi_notify(struct acpi_device *device, u32 event)
{
- struct key_entry *key;
-
acpi_handle_debug(device->handle, "notify: %d\n", event);
- if (inited & INIT_SPARSE_KEYMAP) {
- key = sparse_keymap_entry_from_scancode(wmi_input_dev, 0x80);
- if (key && key->type == KE_KEY)
- sparse_keymap_report_entry(wmi_input_dev, key, 1, true);
- }
}
static ssize_t fan_mode_store(struct device *dev,
--
2.39.2
next prev parent reply other threads:[~2024-06-06 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 23:35 [PATCH 0/4] platform/x86: lg-laptop: Support 2024 models Armin Wolf
2024-06-06 23:35 ` [PATCH 1/4] platform/x86: wireless-hotkey: Add support for LG Airplane Button Armin Wolf
2024-06-06 23:35 ` Armin Wolf [this message]
2024-06-06 23:35 ` [PATCH 3/4] platform/x86: lg-laptop: Change ACPI device id Armin Wolf
2024-06-06 23:35 ` [PATCH 4/4] platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Armin Wolf
2024-06-18 11:58 ` Ilpo Järvinen
2024-06-07 11:33 ` [PATCH 0/4] platform/x86: lg-laptop: Support 2024 models Ilpo Järvinen
2024-06-16 18:35 ` Armin Wolf
2024-06-24 11:29 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606233540.9774-3-W_Armin@gmx.de \
--to=w_armin@gmx.de \
--cc=agathe@boutmy.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matan@svgalib.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®