From: Hans de Goede <hdegoede@redhat.com>
To: Armin Wolf <W_Armin@gmx.de>, matan@svgalib.org, agathe@boutmy.com
Cc: ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] platform/x86: lg-laptop: Support 2024 models
Date: Mon, 24 Jun 2024 13:29:03 +0200 [thread overview]
Message-ID: <22147391-0084-4504-a899-4a529dab1af3@redhat.com> (raw)
In-Reply-To: <20240606233540.9774-1-W_Armin@gmx.de>
Hi,
On 6/7/24 1:35 AM, Armin Wolf wrote:
> A user complained that the lg-laptop driver does not work on 2024
> models like the LG Gram 16Z90S-G.AD7BF. The underlying reason turned
> out to be that the ACPI methods used by this driver where not mapped
> under \XINI, but instead under \_SB.XINI. Those ACPI methods are
> associated with the LGEX0820 ACPI device, which was not used by this
> driver until now.
>
> The first three patches move the airplane mode hotkey handling out
> of lg-laptop and into the wireless-hotkey driver. This necessary
> because the airplane mode hotkey is handled by a different ACPI
> device (LGEX0815).
>
> The last patch finally fixes the underlying issue and uses the
> LGEX0820 ACPI device to find theWMAB/WMBB ACPI methods.
>
> The modified drivers where tested by the user which created the
> bug report and appear to work without issues.
>
> Armin Wolf (4):
> platform/x86: wireless-hotkey: Add support for LG Airplane Button
> platform/x86: lg-laptop: Remove LGEX0815 hotkey handling
> platform/x86: lg-laptop: Change ACPI device id
> platform/x86: lg-laptop: Use ACPI device handle when evaluating
> WMAB/WMBB
Thank you for your patch-series, I've applied this series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.
Regards,
Hans
prev parent reply other threads:[~2024-06-24 11:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 23:35 Armin Wolf
2024-06-06 23:35 ` [PATCH 1/4] platform/x86: wireless-hotkey: Add support for LG Airplane Button Armin Wolf
2024-06-06 23:35 ` [PATCH 2/4] platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Armin Wolf
2024-06-06 23:35 ` [PATCH 3/4] platform/x86: lg-laptop: Change ACPI device id Armin Wolf
2024-06-06 23:35 ` [PATCH 4/4] platform/x86: lg-laptop: Use ACPI device handle when evaluating WMAB/WMBB Armin Wolf
2024-06-18 11:58 ` Ilpo Järvinen
2024-06-07 11:33 ` [PATCH 0/4] platform/x86: lg-laptop: Support 2024 models Ilpo Järvinen
2024-06-16 18:35 ` Armin Wolf
2024-06-24 11:29 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22147391-0084-4504-a899-4a529dab1af3@redhat.com \
--to=hdegoede@redhat.com \
--cc=W_Armin@gmx.de \
--cc=agathe@boutmy.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matan@svgalib.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®