From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: Riwen Lu <luriwen@hotmail.com>,
beata.michalska@arm.com, rafael@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
hotran@apm.com, Riwen Lu <luriwen@kylinos.cn>
Subject: Re: [PATCH v3] cpufreq/cppc: Remove the desired_perf compare when set target
Date: Tue, 11 Jun 2024 14:40:49 +0530 [thread overview]
Message-ID: <20240611091049.lrypvvluntf37uff@vireshk-i7> (raw)
In-Reply-To: <ZmgQ06jtJBPh5wat@arm.com>
On 11-06-24, 09:54, Ionela Voinescu wrote:
> It's alright with me.
Great.
> Some "nits":
> - the "desired_perf" local variable could be removed in this case.
Riwen, please fix this and resend.
> - [note] while this change helps, we'd still need policy->cur to always
> have the latest request value (see details at [1]) for this check to
> be made obsolete by the comparison between target_freq and policy->cur,
> as mentioned in the commit message. But this is/can be a separate
> matter.
>
> [1] https://lore.kernel.org/lkml/ZmB1qKucR5fXk100@arm.com/
Yeah, lets discuss that in the other thread only.
--
viresh
next prev parent reply other threads:[~2024-06-11 9:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 3:22 [PATCH v2] cpufreq/cppc: Take policy->cur into judge " Riwen Lu
2024-05-29 5:36 ` Viresh Kumar
2024-05-29 6:53 ` Riwen Lu
2024-05-29 7:12 ` Viresh Kumar
2024-05-30 1:06 ` Riwen Lu
2024-05-30 5:56 ` Viresh Kumar
2024-05-30 6:02 ` Riwen Lu
2024-05-30 6:16 ` Viresh Kumar
2024-05-30 11:08 ` [PATCH v3] cpufreq/cppc: Remove the desired_perf compare " Riwen Lu
2024-06-06 9:07 ` Viresh Kumar
2024-06-11 8:54 ` Ionela Voinescu
2024-06-11 9:10 ` Viresh Kumar [this message]
2024-06-12 2:52 ` Riwen Lu
2024-06-12 6:24 ` Viresh Kumar
2024-06-12 6:26 ` Viresh Kumar
2024-06-14 12:12 ` Riwen Lu
2024-06-12 9:08 ` Pierre Gondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611091049.lrypvvluntf37uff@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=beata.michalska@arm.com \
--cc=hotran@apm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luriwen@hotmail.com \
--cc=luriwen@kylinos.cn \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®