From: Riwen Lu <luriwen@hotmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Ionela Voinescu <ionela.voinescu@arm.com>,
beata.michalska@arm.com, rafael@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
hotran@apm.com, Riwen Lu <luriwen@kylinos.cn>
Subject: Re: [PATCH v3] cpufreq/cppc: Remove the desired_perf compare when set target
Date: Fri, 14 Jun 2024 20:12:59 +0800 [thread overview]
Message-ID: <OS3P286MB2490D85DD16331E5942BCEC4B1C22@OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240612062404.yjfduze4bvgyts6a@vireshk-i7>
在 2024/6/12 14:24, Viresh Kumar 写道:
> On 12-06-24, 10:52, Riwen Lu wrote:
>> I think it's no need to remove the "desired_perf" local variable here, the
>> code is seems more readable.
>
> There is no need of a temporary variable and I don't think it increases
> readability at all. Moreover, same needs to be done in
> cppc_cpufreq_fast_switch() too.
>
OK. I'll push a patch that remove the desired_perf temporary in
cppc_cpufreq_fast_switch().
next prev parent reply other threads:[~2024-06-14 12:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 3:22 [PATCH v2] cpufreq/cppc: Take policy->cur into judge " Riwen Lu
2024-05-29 5:36 ` Viresh Kumar
2024-05-29 6:53 ` Riwen Lu
2024-05-29 7:12 ` Viresh Kumar
2024-05-30 1:06 ` Riwen Lu
2024-05-30 5:56 ` Viresh Kumar
2024-05-30 6:02 ` Riwen Lu
2024-05-30 6:16 ` Viresh Kumar
2024-05-30 11:08 ` [PATCH v3] cpufreq/cppc: Remove the desired_perf compare " Riwen Lu
2024-06-06 9:07 ` Viresh Kumar
2024-06-11 8:54 ` Ionela Voinescu
2024-06-11 9:10 ` Viresh Kumar
2024-06-12 2:52 ` Riwen Lu
2024-06-12 6:24 ` Viresh Kumar
2024-06-12 6:26 ` Viresh Kumar
2024-06-14 12:12 ` Riwen Lu [this message]
2024-06-12 9:08 ` Pierre Gondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3P286MB2490D85DD16331E5942BCEC4B1C22@OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM \
--to=luriwen@hotmail.com \
--cc=beata.michalska@arm.com \
--cc=hotran@apm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luriwen@kylinos.cn \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®