* [PATCH] mailbox: omap: Fix mailbox interrupt sharing
@ 2024-06-11 17:04 Andrew Davis
2024-06-12 10:55 ` Beleswar Prasad Padhi
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Davis @ 2024-06-11 17:04 UTC (permalink / raw)
To: Jassi Brar, Beleswar Padhi, Hari Nagalla; +Cc: linux-kernel, Andrew Davis
Multiple mailbox users can share one interrupt line. This flag was
mistakenly dropped as part of the FIFO removal. Mark the IRQ as shared.
Reported-by: Beleswar Padhi <b-padhi@ti.com>
Fixes: 3f58c1f4206f ("mailbox: omap: Remove kernel FIFO message queuing")
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/mailbox/omap-mailbox.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
index 46747559b438f..7a87424657a15 100644
--- a/drivers/mailbox/omap-mailbox.c
+++ b/drivers/mailbox/omap-mailbox.c
@@ -230,7 +230,8 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
int ret = 0;
ret = request_threaded_irq(mbox->irq, NULL, mbox_interrupt,
- IRQF_ONESHOT, mbox->name, mbox);
+ IRQF_SHARED | IRQF_ONESHOT, mbox->name,
+ mbox);
if (unlikely(ret)) {
pr_err("failed to register mailbox interrupt:%d\n", ret);
return ret;
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mailbox: omap: Fix mailbox interrupt sharing
2024-06-11 17:04 [PATCH] mailbox: omap: Fix mailbox interrupt sharing Andrew Davis
@ 2024-06-12 10:55 ` Beleswar Prasad Padhi
0 siblings, 0 replies; 2+ messages in thread
From: Beleswar Prasad Padhi @ 2024-06-12 10:55 UTC (permalink / raw)
To: Andrew Davis, Jassi Brar, Hari Nagalla; +Cc: linux-kernel
On 11/06/24 22:34, Andrew Davis wrote:
> Multiple mailbox users can share one interrupt line. This flag was
> mistakenly dropped as part of the FIFO removal. Mark the IRQ as shared.
>
> Reported-by: Beleswar Padhi <b-padhi@ti.com>
> Fixes: 3f58c1f4206f ("mailbox: omap: Remove kernel FIFO message queuing")
> Signed-off-by: Andrew Davis <afd@ti.com>
Tested-by: Beleswar Padhi <b-padhi@ti.com>
> ---
> drivers/mailbox/omap-mailbox.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
> index 46747559b438f..7a87424657a15 100644
> --- a/drivers/mailbox/omap-mailbox.c
> +++ b/drivers/mailbox/omap-mailbox.c
> @@ -230,7 +230,8 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
> int ret = 0;
>
> ret = request_threaded_irq(mbox->irq, NULL, mbox_interrupt,
> - IRQF_ONESHOT, mbox->name, mbox);
> + IRQF_SHARED | IRQF_ONESHOT, mbox->name,
> + mbox);
> if (unlikely(ret)) {
> pr_err("failed to register mailbox interrupt:%d\n", ret);
> return ret;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-12 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-11 17:04 [PATCH] mailbox: omap: Fix mailbox interrupt sharing Andrew Davis
2024-06-12 10:55 ` Beleswar Prasad Padhi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®