From: Rob Herring <robh@kernel.org>
To: Danila Tikhonov <danila@jiaxyga.com>
Cc: jonathan@marek.ca, krzk+dt@kernel.org, quic_khsieh@quicinc.com,
linux-arm-msm@vger.kernel.org, quic_rmccann@quicinc.com,
sean@poorly.run, dmitry.baryshkov@linaro.org,
tzimmermann@suse.de, mripard@kernel.org,
linux-kernel@vger.kernel.org, konrad.dybcio@linaro.org,
dri-devel@lists.freedesktop.org,
maarten.lankhorst@linux.intel.com, daniel@ffwll.ch,
freedreno@lists.freedesktop.org, marijn.suijten@somainline.org,
robdclark@gmail.com, conor+dt@kernel.org, swboyd@chromium.org,
quic_abhinavk@quicinc.com, devicetree@vger.kernel.org,
airlied@gmail.com, quic_jesszhan@quicinc.com,
neil.armstrong@linaro.org
Subject: Re: [PATCH 1/4] dt-bindings: display/msm: Add SM7150 MDSS
Date: Wed, 12 Jun 2024 07:20:03 -0600 [thread overview]
Message-ID: <20240612132003.GA1934293-robh@kernel.org> (raw)
In-Reply-To: <727417e8-781c-435c-8abd-f3dfe6b0e5bb@jiaxyga.com>
On Wed, Jun 12, 2024 at 09:19:35AM +0300, Danila Tikhonov wrote:
> On 6/12/24 03:34, Rob Herring (Arm) wrote:
> > On Wed, 12 Jun 2024 01:37:40 +0300, Danila Tikhonov wrote:
> > > Document the MDSS hardware found on the Qualcomm SM7150 platform.
> > >
> > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> > > ---
> > > .../display/msm/qcom,sm7150-mdss.yaml | 460 ++++++++++++++++++
> > > 1 file changed, 460 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml
> > >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,sm7150-dispcc.h: No such file or directory
> > 25 | #include <dt-bindings/clock/qcom,sm7150-dispcc.h>
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > compilation terminated.
> > make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.example.dtb] Error 1
> > make[2]: *** Waiting for unfinished jobs....
> > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
> > make: *** [Makefile:240: __sub-make] Error 2
> >
> > doc reference errors (make refcheckdocs):
> >
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240611223743.113223-2-danila@jiaxyga.com
> >
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
> >
>
> Yes, this happened because I forgot to add note (same for both dtbindings):
> Depends on commit ca3a91063acc (dt-bindings: clock: qcom: Add SM7150 DISPCC
> clocks)
So then this can't be merged as I imagine that is in a different tree.
Maybe you want to not use the header for the example.
Rob
next prev parent reply other threads:[~2024-06-12 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 22:37 [PATCH 0/4] Add MDSS and DPU support for QCOM SM7150 SoC Danila Tikhonov
2024-06-11 22:37 ` [PATCH 1/4] dt-bindings: display/msm: Add SM7150 MDSS Danila Tikhonov
2024-06-12 0:34 ` Rob Herring (Arm)
2024-06-12 6:19 ` Danila Tikhonov
2024-06-12 13:20 ` Rob Herring [this message]
2024-06-12 13:21 ` Dmitry Baryshkov
2024-06-11 22:37 ` [PATCH 2/4] drm/msm: mdss: Add SM7150 support Danila Tikhonov
2024-06-11 22:37 ` [PATCH 3/4] dt-bindings: display/msm: Add SM7150 DPU Danila Tikhonov
2024-06-11 23:33 ` Rob Herring (Arm)
2024-06-11 22:37 ` [PATCH 4/4] drm/msm/dpu: Add SM7150 support Danila Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612132003.GA1934293-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_rmccann@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®