mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: nspire: Add unit name addresses to memory nodes
@ 2024-06-12 15:13 Andrew Davis
  2024-06-12 15:13 ` [PATCH 2/2] ARM: dts: nspire: Add full compatible for watchdog node Andrew Davis
  2024-06-23 12:21 ` [PATCH 1/2] ARM: dts: nspire: Add unit name addresses to memory nodes Krzysztof Kozlowski
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Davis @ 2024-06-12 15:13 UTC (permalink / raw)
  To: Daniel Tang, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: devicetree, linux-kernel, Andrew Davis

Fixes the following DTB check warning:

> node has a reg or ranges property, but no unit name

Signed-off-by: Andrew Davis <afd@ti.com>
---
 arch/arm/boot/dts/nspire/nspire-classic.dtsi | 2 +-
 arch/arm/boot/dts/nspire/nspire-cx.dts       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nspire/nspire-classic.dtsi b/arch/arm/boot/dts/nspire/nspire-classic.dtsi
index a6e9cbf51524d..0ee53d3ecd542 100644
--- a/arch/arm/boot/dts/nspire/nspire-classic.dtsi
+++ b/arch/arm/boot/dts/nspire/nspire-classic.dtsi
@@ -55,7 +55,7 @@ &vbus_reg {
 };
 
 / {
-	memory {
+	memory@10000000 {
 		device_type = "memory";
 		reg = <0x10000000 0x2000000>; /* 32 MB */
 	};
diff --git a/arch/arm/boot/dts/nspire/nspire-cx.dts b/arch/arm/boot/dts/nspire/nspire-cx.dts
index 29f0181e5b385..debeff0ec010f 100644
--- a/arch/arm/boot/dts/nspire/nspire-cx.dts
+++ b/arch/arm/boot/dts/nspire/nspire-cx.dts
@@ -122,7 +122,7 @@ / {
 	model = "TI-NSPIRE CX";
 	compatible = "ti,nspire-cx";
 
-	memory {
+	memory@10000000 {
 		device_type = "memory";
 		reg = <0x10000000 0x4000000>; /* 64 MB */
 	};
-- 
2.39.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ARM: dts: nspire: Add full compatible for watchdog node
  2024-06-12 15:13 [PATCH 1/2] ARM: dts: nspire: Add unit name addresses to memory nodes Andrew Davis
@ 2024-06-12 15:13 ` Andrew Davis
  2024-06-23 12:21 ` [PATCH 1/2] ARM: dts: nspire: Add unit name addresses to memory nodes Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Davis @ 2024-06-12 15:13 UTC (permalink / raw)
  To: Daniel Tang, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: devicetree, linux-kernel, Andrew Davis

The watchdog appears to be an ARM SP805, add the full compatible
and the needed clocks properties. Leave this disabled for now
as functionality is not fully tested.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 arch/arm/boot/dts/nspire/nspire.dtsi | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nspire/nspire.dtsi b/arch/arm/boot/dts/nspire/nspire.dtsi
index d56fef7250dbd..95588b716c6f3 100644
--- a/arch/arm/boot/dts/nspire/nspire.dtsi
+++ b/arch/arm/boot/dts/nspire/nspire.dtsi
@@ -170,9 +170,12 @@ timer1: timer@900d0000 {
 			};
 
 			watchdog: watchdog@90060000 {
-				compatible = "arm,primecell";
+				compatible = "arm,sp805", "arm,primecell";
 				reg = <0x90060000 0x1000>;
 				interrupts = <3>;
+				clocks = <&apb_pclk>, <&apb_pclk>;
+				clock-names = "wdog_clk", "apb_pclk";
+				status = "disabled";
 			};
 
 			rtc: rtc@90090000 {
-- 
2.39.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ARM: dts: nspire: Add unit name addresses to memory nodes
  2024-06-12 15:13 [PATCH 1/2] ARM: dts: nspire: Add unit name addresses to memory nodes Andrew Davis
  2024-06-12 15:13 ` [PATCH 2/2] ARM: dts: nspire: Add full compatible for watchdog node Andrew Davis
@ 2024-06-23 12:21 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-23 12:21 UTC (permalink / raw)
  To: Daniel Tang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Andrew Davis
  Cc: Krzysztof Kozlowski, devicetree, linux-kernel


On Wed, 12 Jun 2024 10:13:13 -0500, Andrew Davis wrote:
> Fixes the following DTB check warning:
> 
> > node has a reg or ranges property, but no unit name
> 
> 

Applied, thanks!

[1/2] ARM: dts: nspire: Add unit name addresses to memory nodes
      https://git.kernel.org/krzk/linux-dt/c/af88df12762dab540d02c13324a0767473322f1e
[2/2] ARM: dts: nspire: Add full compatible for watchdog node
      https://git.kernel.org/krzk/linux-dt/c/c322d10fe52138b2d47e3b8dd65c20d705e1c313

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-23 12:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-12 15:13 [PATCH 1/2] ARM: dts: nspire: Add unit name addresses to memory nodes Andrew Davis
2024-06-12 15:13 ` [PATCH 2/2] ARM: dts: nspire: Add full compatible for watchdog node Andrew Davis
2024-06-23 12:21 ` [PATCH 1/2] ARM: dts: nspire: Add unit name addresses to memory nodes Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®