[PATCH] irqchip/loongson-eiointc: Use early_cpu_to_node() instead of cpu_to_node()

[PATCH] irqchip/loongson-eiointc: Use early_cpu_to_node() instead of cpu_to_node()

[Huacai Chen]

When we use "nr_cpus=n" to hard limit the CPU number, cpu_to_node() is
not usable because it can only applied on "possible" CPUs. On the other
hand, early_cpu_to_node() can be always used instead.

Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
 drivers/irqchip/irq-loongson-eiointc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c
index c7ddebf312ad..8ba9082c1796 100644
--- a/drivers/irqchip/irq-loongson-eiointc.c
+++ b/drivers/irqchip/irq-loongson-eiointc.c
@@ -339,7 +339,7 @@ static int __init pch_msi_parse_madt(union acpi_subtable_headers *header,
 	int node;
 
 	if (cpu_has_flatmode)
-		node = cpu_to_node(eiointc_priv[nr_pics - 1]->node * CORES_PER_EIO_NODE);
+		node = early_cpu_to_node(eiointc_priv[nr_pics - 1]->node * CORES_PER_EIO_NODE);
 	else
 		node = eiointc_priv[nr_pics - 1]->node;
 
@@ -431,7 +431,7 @@ int __init eiointc_acpi_init(struct irq_domain *parent,
 		goto out_free_handle;
 
 	if (cpu_has_flatmode)
-		node = cpu_to_node(acpi_eiointc->node * CORES_PER_EIO_NODE);
+		node = early_cpu_to_node(acpi_eiointc->node * CORES_PER_EIO_NODE);
 	else
 		node = acpi_eiointc->node;
 	acpi_set_vec_parent(node, priv->eiointc_domain, pch_group);
-- 
2.43.0

Re: [PATCH] irqchip/loongson-eiointc: Use early_cpu_to_node() instead of cpu_to_node()

[kernel test robot]

Hi Huacai,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on linus/master v6.10-rc4 next-20240618]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/irqchip-loongson-eiointc-Use-early_cpu_to_node-instead-of-cpu_to_node/20240618-183129
base:   tip/irq/core
patch link:    https://lore.kernel.org/r/20240618081507.3996921-1-chenhuacai%40loongson.cn
patch subject: [PATCH] irqchip/loongson-eiointc: Use early_cpu_to_node() instead of cpu_to_node()
config: loongarch-alldefconfig (https://download.01.org/0day-ci/archive/20240619/202406190940.wW8qmA6Q-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240619/202406190940.wW8qmA6Q-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406190940.wW8qmA6Q-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/irqchip/irq-loongson-eiointc.c: In function 'pch_msi_parse_madt':
>> drivers/irqchip/irq-loongson-eiointc.c:342:24: error: implicit declaration of function 'early_cpu_to_node'; did you mean 'early_pfn_to_nid'? [-Werror=implicit-function-declaration]
     342 |                 node = early_cpu_to_node(eiointc_priv[nr_pics - 1]->node * CORES_PER_EIO_NODE);
         |                        ^~~~~~~~~~~~~~~~~
         |                        early_pfn_to_nid
   cc1: some warnings being treated as errors


vim +342 drivers/irqchip/irq-loongson-eiointc.c

   333	
   334	static int __init pch_msi_parse_madt(union acpi_subtable_headers *header,
   335						const unsigned long end)
   336	{
   337		struct irq_domain *parent;
   338		struct acpi_madt_msi_pic *pchmsi_entry = (struct acpi_madt_msi_pic *)header;
   339		int node;
   340	
   341		if (cpu_has_flatmode)
 > 342			node = early_cpu_to_node(eiointc_priv[nr_pics - 1]->node * CORES_PER_EIO_NODE);
   343		else
   344			node = eiointc_priv[nr_pics - 1]->node;
   345	
   346		parent = acpi_get_vec_parent(node, msi_group);
   347	
   348		if (parent)
   349			return pch_msi_acpi_init(parent, pchmsi_entry);
   350	
   351		return 0;
   352	}
   353	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki