mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] x86/xen/time: Reduce Xen timer tick
@ 2024-06-19 10:40 Frediano Ziglio
  2024-07-01  8:25 ` Jürgen Groß
  0 siblings, 1 reply; 2+ messages in thread
From: Frediano Ziglio @ 2024-06-19 10:40 UTC (permalink / raw)
  To: xen-devel, linux-kernel
  Cc: H. Peter Anvin, x86, Dave Hansen, Borislav Petkov, Ingo Molnar,
	Thomas Gleixner, Boris Ostrovsky, Juergen Gross, Frediano Ziglio

Current timer tick is causing some deadline to fail.
The current high value constant was probably due to an old
bug in the Xen timer implementation causing errors if the
deadline was in the future.

This was fixed in Xen commit:
19c6cbd90965 xen/vcpu: ignore VCPU_SSHOTTMR_future

Usage of VCPU_SSHOTTMR_future in Linux kernel was removed by:
c06b6d70feb3 xen/x86: don't lose event interrupts

Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
 arch/x86/xen/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Changes since v1:
- Update commit message;
- reduce delay.

diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index 52fa5609b7f6..96521b1874ac 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -30,7 +30,7 @@
 #include "xen-ops.h"
 
 /* Minimum amount of time until next clock event fires */
-#define TIMER_SLOP	100000
+#define TIMER_SLOP	1
 
 static u64 xen_sched_clock_offset __read_mostly;
 
-- 
2.45.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] x86/xen/time: Reduce Xen timer tick
  2024-06-19 10:40 [PATCH v2] x86/xen/time: Reduce Xen timer tick Frediano Ziglio
@ 2024-07-01  8:25 ` Jürgen Groß
  0 siblings, 0 replies; 2+ messages in thread
From: Jürgen Groß @ 2024-07-01  8:25 UTC (permalink / raw)
  To: Frediano Ziglio, xen-devel, linux-kernel
  Cc: H. Peter Anvin, x86, Dave Hansen, Borislav Petkov, Ingo Molnar,
	Thomas Gleixner, Boris Ostrovsky

On 19.06.24 12:40, Frediano Ziglio wrote:
> Current timer tick is causing some deadline to fail.
> The current high value constant was probably due to an old
> bug in the Xen timer implementation causing errors if the
> deadline was in the future.
> 
> This was fixed in Xen commit:
> 19c6cbd90965 xen/vcpu: ignore VCPU_SSHOTTMR_future
> 
> Usage of VCPU_SSHOTTMR_future in Linux kernel was removed by:
> c06b6d70feb3 xen/x86: don't lose event interrupts
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-07-01  8:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-19 10:40 [PATCH v2] x86/xen/time: Reduce Xen timer tick Frediano Ziglio
2024-07-01  8:25 ` Jürgen Groß

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®