mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikunj A Dadhania <nikunj@amd.com>
To: <linux-kernel@vger.kernel.org>, <thomas.lendacky@amd.com>,
	<bp@alien8.de>, <x86@kernel.org>, <kvm@vger.kernel.org>
Cc: <mingo@redhat.com>, <tglx@linutronix.de>,
	<dave.hansen@linux.intel.com>, <pgonda@google.com>,
	<seanjc@google.com>, <pbonzini@redhat.com>, <nikunj@amd.com>
Subject: [PATCH v10 05/24] virt: sev-guest: Fix user-visible strings
Date: Fri, 21 Jun 2024 18:08:44 +0530	[thread overview]
Message-ID: <20240621123903.2411843-6-nikunj@amd.com> (raw)
In-Reply-To: <20240621123903.2411843-1-nikunj@amd.com>

User-visible abbreviations should be in capitals, ensure messages are
readable and clear.

No functional change.

Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
---
 drivers/virt/coco/sev-guest/sev-guest.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
index 85e3d39bd5a9..61e190ecfa3a 100644
--- a/drivers/virt/coco/sev-guest/sev-guest.c
+++ b/drivers/virt/coco/sev-guest/sev-guest.c
@@ -105,7 +105,7 @@ static bool is_vmpck_empty(struct snp_guest_dev *snp_dev)
  */
 static void snp_disable_vmpck(struct snp_guest_dev *snp_dev)
 {
-	dev_alert(snp_dev->dev, "Disabling vmpck_id %d to prevent IV reuse.\n",
+	dev_alert(snp_dev->dev, "Disabling VMPCK%d communication key to prevent IV reuse.\n",
 		  vmpck_id);
 	memzero_explicit(snp_dev->vmpck, VMPCK_KEY_LEN);
 	snp_dev->vmpck = NULL;
@@ -1040,13 +1040,13 @@ static int __init sev_guest_probe(struct platform_device *pdev)
 	ret = -EINVAL;
 	snp_dev->vmpck = get_vmpck(vmpck_id, secrets, &snp_dev->os_area_msg_seqno);
 	if (!snp_dev->vmpck) {
-		dev_err(dev, "invalid vmpck id %d\n", vmpck_id);
+		dev_err(dev, "Invalid VMPCK%d communication key\n", vmpck_id);
 		goto e_unmap;
 	}
 
 	/* Verify that VMPCK is not zero. */
 	if (is_vmpck_empty(snp_dev)) {
-		dev_err(dev, "vmpck id %d is null\n", vmpck_id);
+		dev_err(dev, "Empty VMPCK%d communication key\n", vmpck_id);
 		goto e_unmap;
 	}
 
@@ -1105,7 +1105,7 @@ static int __init sev_guest_probe(struct platform_device *pdev)
 	if (ret)
 		goto e_free_ctx;
 
-	dev_info(dev, "Initialized SEV guest driver (using vmpck_id %d)\n", vmpck_id);
+	dev_info(dev, "Initialized SEV guest driver (using VMPCK%d communication key)\n", vmpck_id);
 	return 0;
 
 e_free_ctx:
-- 
2.34.1


  parent reply	other threads:[~2024-06-21 12:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 12:38 [PATCH v10 00/24] Add Secure TSC support for SNP guests Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 01/24] virt: sev-guest: Use AES GCM crypto library Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 02/24] virt: sev-guest: Replace dev_dbg with pr_debug Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 03/24] virt: sev-guest: Make payload a variable length array Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 04/24] virt: sev-guest: Add SNP guest request structure Nikunj A Dadhania
2024-06-21 12:38 ` Nikunj A Dadhania [this message]
2024-06-21 12:38 ` [PATCH v10 06/24] virt: sev-guest: Simplify VMPCK and sequence number assignments Nikunj A Dadhania
2024-06-25 17:04   ` Borislav Petkov
2024-06-28  4:25     ` Nikunj A. Dadhania
2024-06-28  5:48       ` Borislav Petkov
2024-06-21 12:38 ` [PATCH v10 07/24] virt: sev-guest: Store VMPCK index to SNP guest device structure Nikunj A Dadhania
2024-06-28  3:52   ` Borislav Petkov
2024-07-01 10:45     ` Nikunj A. Dadhania
2024-07-01 12:41       ` Borislav Petkov
2024-06-21 12:38 ` [PATCH v10 08/24] virt: sev-guest: Take mutex in snp_send_guest_request() Nikunj A Dadhania
2024-06-28  8:39   ` Borislav Petkov
2024-06-21 12:38 ` [PATCH v10 09/24] virt: sev-guest: Carve out SNP guest messaging init/exit Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 10/24] x86/sev: Move core SEV guest driver routines to common code Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 11/24] x86/sev: Replace dev_[err,alert] with pr_[err,alert] Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 12/24] x86/sev: Make snp_issue_guest_request() static Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 13/24] x86/sev: Make sev-guest driver functional again Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 14/24] x86/sev: Handle failures from snp_init() Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 15/24] x86/sev: Cache the secrets page address Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 16/24] x86/sev: Drop sev_guest_platform_data structure Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 17/24] x86/cc: Add CC_ATTR_GUEST_SECURE_TSC Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 18/24] x86/sev: Add Secure TSC support for SNP guests Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 19/24] x86/sev: Change TSC MSR behavior for Secure TSC enabled guests Nikunj A Dadhania
2024-06-21 12:38 ` [PATCH v10 20/24] x86/sev: Prevent RDTSC/RDTSCP interception " Nikunj A Dadhania
2024-06-21 12:39 ` [PATCH v10 21/24] x86/kvmclock: Skip kvmclock when Secure TSC is available Nikunj A Dadhania
2024-06-21 12:39 ` [PATCH v10 22/24] x86/sev: Mark Secure TSC as reliable Nikunj A Dadhania
2024-06-21 12:39 ` [PATCH v10 23/24] x86/cpu/amd: Do not print FW_BUG for Secure TSC Nikunj A Dadhania
2024-06-21 12:39 ` [PATCH v10 24/24] x86/sev: Enable Secure TSC for SNP guests Nikunj A Dadhania

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621123903.2411843-6-nikunj@amd.com \
    --to=nikunj@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pgonda@google.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®