[PATCH 1/1] dt-bindings: nvmem: sfp: add child node unique-id

[PATCH 1/1] dt-bindings: nvmem: sfp: add child node unique-id

[Frank Li]

Add child node unique-id to fix below CHECK_DTBS warning.
efuse@1e80000: Unevaluated properties are not allowed ('unique-id@1c' was unexpected)

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../bindings/nvmem/fsl,layerscape-sfp.yaml      | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
index 70fb2ad251037..8c0bdaab711a7 100644
--- a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
+++ b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
@@ -42,6 +42,23 @@ properties:
       The regulator for the TA_PROG_SFP pin. It will be enabled for programming
       and disabled for reading.
 
+patternProperties:
+  '^unique-id@[0-9a-f]*$':
+    type: object
+    description:
+      Chip unique id.
+
+    properties:
+      reg:
+        description:
+          Byte offset where the unique id is stored
+        maxItems: 1
+
+    required:
+      - reg
+
+    additionalProperties: false
+
 required:
   - compatible
   - reg
-- 
2.34.1

Re: [PATCH 1/1] dt-bindings: nvmem: sfp: add child node unique-id

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]

On Fri, Jun 21, 2024 at 12:56:37PM -0400, Frank Li wrote:
> Add child node unique-id to fix below CHECK_DTBS warning.
> efuse@1e80000: Unevaluated properties are not allowed ('unique-id@1c' was unexpected)

That's not sufficient justification. Why is this even needed? What can't
it be determined from a compatible etc? Just because it slipped into a
dts doesn't mean you get to avoid the usual requirements for justifying
new properties.

Thanks,
Conor.

> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../bindings/nvmem/fsl,layerscape-sfp.yaml      | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> index 70fb2ad251037..8c0bdaab711a7 100644
> --- a/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml
> @@ -42,6 +42,23 @@ properties:
>        The regulator for the TA_PROG_SFP pin. It will be enabled for programming
>        and disabled for reading.
>  
> +patternProperties:
> +  '^unique-id@[0-9a-f]*$':
> +    type: object
> +    description:
> +      Chip unique id.
> +
> +    properties:
> +      reg:
> +        description:
> +          Byte offset where the unique id is stored
> +        maxItems: 1
> +
> +    required:
> +      - reg
> +
> +    additionalProperties: false
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]