mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] media: i2c: thp7312: Convert comma to semicolon
@ 2024-07-02  2:57 Chen Ni
  2024-07-02  7:36 ` Paul Elder
  2024-07-02  7:48 ` Laurent Pinchart
  0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2024-07-02  2:57 UTC (permalink / raw)
  To: laurent.pinchart, paul.elder, mchehab; +Cc: linux-media, linux-kernel, Chen Ni

Replace a comma between expression statements by a semicolon.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/media/i2c/thp7312.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/thp7312.c b/drivers/media/i2c/thp7312.c
index 19bd923a7315..75225ff5eff6 100644
--- a/drivers/media/i2c/thp7312.c
+++ b/drivers/media/i2c/thp7312.c
@@ -1503,7 +1503,7 @@ static int __thp7312_flash_reg_read(struct thp7312_device *thp7312,
 
 	msgs[0].addr = client->addr;
 	msgs[0].flags = 0;
-	msgs[0].len = sizeof(thp7312_cmd_read_reg),
+	msgs[0].len = sizeof(thp7312_cmd_read_reg);
 	msgs[0].buf = (u8 *)thp7312_cmd_read_reg;
 
 	msgs[1].addr = client->addr;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: i2c: thp7312: Convert comma to semicolon
  2024-07-02  2:57 [PATCH] media: i2c: thp7312: Convert comma to semicolon Chen Ni
@ 2024-07-02  7:36 ` Paul Elder
  2024-07-02  7:48 ` Laurent Pinchart
  1 sibling, 0 replies; 3+ messages in thread
From: Paul Elder @ 2024-07-02  7:36 UTC (permalink / raw)
  To: Chen Ni; +Cc: laurent.pinchart, mchehab, linux-media, linux-kernel

On Tue, Jul 02, 2024 at 10:57:11AM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  drivers/media/i2c/thp7312.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/thp7312.c b/drivers/media/i2c/thp7312.c
> index 19bd923a7315..75225ff5eff6 100644
> --- a/drivers/media/i2c/thp7312.c
> +++ b/drivers/media/i2c/thp7312.c
> @@ -1503,7 +1503,7 @@ static int __thp7312_flash_reg_read(struct thp7312_device *thp7312,
>  
>  	msgs[0].addr = client->addr;
>  	msgs[0].flags = 0;
> -	msgs[0].len = sizeof(thp7312_cmd_read_reg),
> +	msgs[0].len = sizeof(thp7312_cmd_read_reg);
>  	msgs[0].buf = (u8 *)thp7312_cmd_read_reg;
>  
>  	msgs[1].addr = client->addr;
> -- 
> 2.25.1
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: i2c: thp7312: Convert comma to semicolon
  2024-07-02  2:57 [PATCH] media: i2c: thp7312: Convert comma to semicolon Chen Ni
  2024-07-02  7:36 ` Paul Elder
@ 2024-07-02  7:48 ` Laurent Pinchart
  1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2024-07-02  7:48 UTC (permalink / raw)
  To: Chen Ni; +Cc: paul.elder, mchehab, linux-media, linux-kernel

Hello Chen,

Thank you for the patch.

On Tue, Jul 02, 2024 at 10:57:11AM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.

Oops.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/media/i2c/thp7312.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/thp7312.c b/drivers/media/i2c/thp7312.c
> index 19bd923a7315..75225ff5eff6 100644
> --- a/drivers/media/i2c/thp7312.c
> +++ b/drivers/media/i2c/thp7312.c
> @@ -1503,7 +1503,7 @@ static int __thp7312_flash_reg_read(struct thp7312_device *thp7312,
>  
>  	msgs[0].addr = client->addr;
>  	msgs[0].flags = 0;
> -	msgs[0].len = sizeof(thp7312_cmd_read_reg),
> +	msgs[0].len = sizeof(thp7312_cmd_read_reg);
>  	msgs[0].buf = (u8 *)thp7312_cmd_read_reg;
>  
>  	msgs[1].addr = client->addr;

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-02  7:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-02  2:57 [PATCH] media: i2c: thp7312: Convert comma to semicolon Chen Ni
2024-07-02  7:36 ` Paul Elder
2024-07-02  7:48 ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®