From: Borislav Petkov <bp@alien8.de>
To: John Allen <john.allen@amd.com>
Cc: rafael@kernel.org, lenb@kernel.org, yazen.ghannam@amd.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH v2 2/2] RAS/AMD/ATL: Translate normalized to system physical addresses using PRM
Date: Thu, 4 Jul 2024 00:46:11 +0200 [thread overview]
Message-ID: <20240703224611.GDZoXUs7INLbRM4v1a@fat_crate.local> (raw)
In-Reply-To: <ZoWxPR+A3xjV1Y/j@AUS-L1-JOHALLEN.amd.com>
On Wed, Jul 03, 2024 at 03:14:53PM -0500, John Allen wrote:
> I'm not sure this works the way we need it to. If ACPI_PRMT is not
> enabled, then the norm to sys translation function will be referenced by
> the base AMD ATL, but will the symbol will not be found since the the
> PRM file doesn't get compiled.
So you don't delete the stub but you put it in the internal.h header:
#ifndef CONFIG_AMD_ATL_PRM
+unsigned long prm_umc_norm_to_sys_addr(u8 socket_id, u64 umc_bank_inst_id, unsigned long addr)
+{
+ return -ENODEV;
+}
+
+#endif
Don't be afraid to grep the tree - there are gazillion examples how stuff like
that is usually done.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2024-07-03 22:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 17:47 [PATCH v2 0/2] PRM handler direct call interface John Allen
2024-05-06 17:47 ` [PATCH v2 1/2] ACPI: PRM: Add PRM handler direct call support John Allen
2024-06-26 19:21 ` Rafael J. Wysocki
2024-06-27 8:08 ` Borislav Petkov
2024-07-02 14:54 ` Ard Biesheuvel
2024-05-06 17:47 ` [PATCH v2 2/2] RAS/AMD/ATL: Translate normalized to system physical addresses using PRM John Allen
2024-06-28 7:45 ` Borislav Petkov
2024-07-01 16:23 ` John Allen
2024-07-01 16:35 ` Borislav Petkov
2024-07-01 16:43 ` John Allen
2024-07-01 16:59 ` Borislav Petkov
2024-07-03 20:14 ` John Allen
2024-07-03 22:46 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703224611.GDZoXUs7INLbRM4v1a@fat_crate.local \
--to=bp@alien8.de \
--cc=john.allen@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®