Re: [PATCH v2 2/2] RAS/AMD/ATL: Translate normalized to system physical addresses using PRM

[John Allen <john.allen@amd.com>]

On Mon, Jul 01, 2024 at 06:35:05PM +0200, Borislav Petkov wrote:
> On Mon, Jul 01, 2024 at 11:23:36AM -0500, John Allen wrote:
> > This is the param buffer struct used for norm -> X tranlations. I can
> > shorten and clarify this along with the others you pointed out. Maybe
> > "param_buffer_norm" instead and a comment explaining the purpose?
> 
> What's wrong with
> 
> struct param_buffer
> 
> simply?
> 
> It is obvious from the code that it is used in the normalized -> physical
> address translation.

This is because the spec defines different param buffer structures for
different types of translation. We can call this just param_buffer for
now, but would need to be renamed if/when we add use cases for the other
translation handlers. My preference would be to sort of future-proof
the name now, but I don't have an issue calling it param_buffer now and
changing it later if that's what you'd prefer.

> Btw, pls do me a favor and trim your replies like I just did.

Sure, sorry about that.

Thanks,
John