From: Eugen Hristev <eugen.hristev@collabora.com>
To: viro@zeniv.linux.org.uk, brauner@kernel.org, tytso@mit.edu,
linux-ext4@vger.kernel.org
Cc: jack@suse.cz, adilger.kernel@dilger.ca,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
krisman@suse.de, kernel@collabora.com,
shreeya.patel@collabora.com,
Eugen Hristev <eugen.hristev@collabora.com>
Subject: [PATCH 0/2] fs/dcache: fix cache inconsistency on case-insensitive lookups
Date: Fri, 5 Jul 2024 09:26:19 +0300 [thread overview]
Message-ID: <20240705062621.630604-1-eugen.hristev@collabora.com> (raw)
Hello,
This is an attempt to go back to this old patch series here :
https://lore.kernel.org/lkml/cover.1632909358.git.shreeya.patel@collabora.com/
First patch fixes a possible hang when d_add_ci is called from a filesystem's
lookup function (like xfs is doing)
d_alloc_parallel -> lookup -> d_add_ci -> d_alloc_parallel
Second patch solves the issue of having the dcache saving the entry with
the same case as it's being looked up instead of saving the real file name
from the storage.
Please check above thread for motivation on why this should be changed.
Some further old discussions here as well:
https://patchwork.ozlabs.org/project/linux-ext4/patch/20180924215655.3676-20-krisman@collabora.co.uk/
I am not sure whether this is the right way to fix this, but I think
I have considered all cases discussed in previous threads.
Thank you for your review and consideration,
Eugen
Eugen Hristev (2):
fs/dcache: introduce d_alloc_parallel_check_existing
ext4: in lookup call d_add_ci if there is a case mismatch
fs/dcache.c | 29 +++++++++++++++++++++++------
fs/ext4/namei.c | 13 +++++++++++++
include/linux/dcache.h | 4 ++++
3 files changed, 40 insertions(+), 6 deletions(-)
--
2.34.1
next reply other threads:[~2024-07-05 6:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 6:26 Eugen Hristev [this message]
2024-07-05 6:26 ` [PATCH 1/2] fs/dcache: introduce d_alloc_parallel_check_existing Eugen Hristev
2024-08-20 20:16 ` Gabriel Krisman Bertazi
2024-08-21 9:10 ` Eugen Hristev
2024-08-21 23:22 ` Gabriel Krisman Bertazi
2024-08-22 1:13 ` Al Viro
2024-08-22 17:25 ` Gabriel Krisman Bertazi
2024-07-05 6:26 ` [PATCH 2/2] ext4: in lookup call d_add_ci if there is a case mismatch Eugen Hristev
2024-08-15 6:02 ` [PATCH 0/2] fs/dcache: fix cache inconsistency on case-insensitive lookups Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705062621.630604-1-eugen.hristev@collabora.com \
--to=eugen.hristev@collabora.com \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kernel@collabora.com \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreeya.patel@collabora.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®