From: Eugen Hristev <eugen.hristev@collabora.com>
To: viro@zeniv.linux.org.uk, brauner@kernel.org, tytso@mit.edu,
linux-ext4@vger.kernel.org
Cc: jack@suse.cz, adilger.kernel@dilger.ca,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
krisman@suse.de, kernel@collabora.com,
shreeya.patel@collabora.com,
Eugen Hristev <eugen.hristev@collabora.com>
Subject: [PATCH 2/2] ext4: in lookup call d_add_ci if there is a case mismatch
Date: Fri, 5 Jul 2024 09:26:21 +0300 [thread overview]
Message-ID: <20240705062621.630604-3-eugen.hristev@collabora.com> (raw)
In-Reply-To: <20240705062621.630604-1-eugen.hristev@collabora.com>
In lookup function, if we have a file match but not a case match in the
case-insensitive case, call d_add_ci to store the real filename into cache
instead of the case variant of the name that was looked up.
This avoids exposing into user space (e.g. /proc/self/cwd) internal cache
data.
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
fs/ext4/namei.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index e6769b97a970..0676c21e1622 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1834,6 +1834,19 @@ static struct dentry *ext4_lookup(struct inode *dir, struct dentry *dentry, unsi
return NULL;
}
+ /* Create a case-insensitive cache entry with the real
+ * name stored, in case our search pattern differs
+ * in terms of case.
+ */
+ if (inode && IS_CASEFOLDED(dir) &&
+ memcmp(de->name, dentry->d_name.name, de->name_len)) {
+ struct qstr dname;
+
+ dname.len = de->name_len;
+ dname.name = de->name;
+ return d_add_ci(dentry, inode, &dname);
+ }
+
return d_splice_alias(inode, dentry);
}
--
2.34.1
next prev parent reply other threads:[~2024-07-05 6:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 6:26 [PATCH 0/2] fs/dcache: fix cache inconsistency on case-insensitive lookups Eugen Hristev
2024-07-05 6:26 ` [PATCH 1/2] fs/dcache: introduce d_alloc_parallel_check_existing Eugen Hristev
2024-08-20 20:16 ` Gabriel Krisman Bertazi
2024-08-21 9:10 ` Eugen Hristev
2024-08-21 23:22 ` Gabriel Krisman Bertazi
2024-08-22 1:13 ` Al Viro
2024-08-22 17:25 ` Gabriel Krisman Bertazi
2024-07-05 6:26 ` Eugen Hristev [this message]
2024-08-15 6:02 ` [PATCH 0/2] fs/dcache: fix cache inconsistency on case-insensitive lookups Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705062621.630604-3-eugen.hristev@collabora.com \
--to=eugen.hristev@collabora.com \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kernel@collabora.com \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreeya.patel@collabora.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®