* [PATCH] Updating a deprecated use of strcpy in ac.c file.
@ 2024-07-06 7:45 Muhammad Qasim Abdul Majeed
2024-08-02 14:37 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Qasim Abdul Majeed @ 2024-07-06 7:45 UTC (permalink / raw)
To: rafael, lenb, linux-acpi, linux-kernel; +Cc: Muhammad Qasim Abdul Majeed
Replacing strcpy with strscpy.
strcpy is a deprecated function.
It should be removed from the kernel source.
Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com>
---
drivers/acpi/ac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
index 09a87fa222c7..ad1427a384e4 100644
--- a/drivers/acpi/ac.c
+++ b/drivers/acpi/ac.c
@@ -213,8 +213,8 @@ static int acpi_ac_probe(struct platform_device *pdev)
return -ENOMEM;
ac->device = adev;
- strcpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME);
- strcpy(acpi_device_class(adev), ACPI_AC_CLASS);
+ strscpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME);
+ strscpy(acpi_device_class(adev), ACPI_AC_CLASS);
platform_set_drvdata(pdev, ac);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Updating a deprecated use of strcpy in ac.c file.
2024-07-06 7:45 [PATCH] Updating a deprecated use of strcpy in ac.c file Muhammad Qasim Abdul Majeed
@ 2024-08-02 14:37 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2024-08-02 14:37 UTC (permalink / raw)
To: Muhammad Qasim Abdul Majeed; +Cc: rafael, lenb, linux-acpi, linux-kernel
On Sat, Jul 6, 2024 at 9:48 AM Muhammad Qasim Abdul Majeed
<qasim.majeed20@gmail.com> wrote:
>
> Replacing strcpy with strscpy.
> strcpy is a deprecated function.
> It should be removed from the kernel source.
>
> Link: https://github.com/KSPP/linux/issues/88
>
> Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com>
> ---
> drivers/acpi/ac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 09a87fa222c7..ad1427a384e4 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -213,8 +213,8 @@ static int acpi_ac_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> ac->device = adev;
> - strcpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME);
> - strcpy(acpi_device_class(adev), ACPI_AC_CLASS);
> + strscpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME);
> + strscpy(acpi_device_class(adev), ACPI_AC_CLASS);
>
> platform_set_drvdata(pdev, ac);
>
> --
Please see this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=142acc42a7443f377b1a452ce906dc3adec91f70
and format the subjects and changelogs of all of your ACPI patches
that replace strcpy() with strscpy() in analogy with it.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-02 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-06 7:45 [PATCH] Updating a deprecated use of strcpy in ac.c file Muhammad Qasim Abdul Majeed
2024-08-02 14:37 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®