* [PATCH] driver:core: no need to invert the return value of the call_driver_probe()
@ 2024-07-07 11:22 Lizhe
0 siblings, 0 replies; only message in thread
From: Lizhe @ 2024-07-07 11:22 UTC (permalink / raw)
To: gregkh, rafael; +Cc: linux-kernel, Lizhe
If drv->probe() or drv->bus->probe() returns EPROBE_DEFER,
then there is no need to invert the sign. Similarly,
if it returns -EPROBE_DEFER, no sign inversion is needed either
In the probe function (either bus->probe() or drv->probe()),
there is no return value of EPROBE_DEFER.
Signed-off-by: Lizhe <sensor1010@163.com>
---
drivers/base/dd.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 83d352394fdf..d047919d1f5e 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -664,11 +664,6 @@ static int really_probe(struct device *dev, struct device_driver *drv)
if (link_ret == -EAGAIN)
ret = -EPROBE_DEFER;
- /*
- * Return probe errors as positive values so that the callers
- * can distinguish them from other errors.
- */
- ret = -ret;
goto probe_failed;
}
@@ -826,7 +821,7 @@ static int driver_probe_device(struct device_driver *drv, struct device *dev)
atomic_inc(&probe_count);
ret = __driver_probe_device(drv, dev);
- if (ret == -EPROBE_DEFER || ret == EPROBE_DEFER) {
+ if (ret == -EPROBE_DEFER) {
driver_deferred_probe_add(dev);
/*
--
2.17.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-07-07 11:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-07 11:22 [PATCH] driver:core: no need to invert the return value of the call_driver_probe() Lizhe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®