[PATCH v1] driver:core: no need to invert the return value of the call_driver_probe()

[PATCH v1] driver:core: no need to invert the return value of the call_driver_probe()

[Lizhe]

If drv->probe() or drv->bus->probe() returns EPROBE_DEFER,
then there is no need to invert the sign. Similarly,
if it returns -EPROBE_DEFER, no sign inversion is needed either

In the probe function (either bus->probe() or drv->probe()),
there is no return value of EPROBE_DEFER.

Signed-off-by: Lizhe <sensor1010@163.com>
---
 drivers/base/dd.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 83d352394fdf..cbf7fe6aa8e0 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -664,11 +664,6 @@ static int really_probe(struct device *dev, struct device_driver *drv)
 		if (link_ret == -EAGAIN)
 			ret = -EPROBE_DEFER;
 
-		/*
-		 * Return probe errors as positive values so that the callers
-		 * can distinguish them from other errors.
-		 */
-		ret = -ret;
 		goto probe_failed;
 	}
 
-- 
2.17.1

Re: [PATCH v1] driver:core: no need to invert the return value of the call_driver_probe()

[Greg KH]

On Sun, Jul 07, 2024 at 04:27:38AM -0700, Lizhe wrote:
> If drv->probe() or drv->bus->probe() returns EPROBE_DEFER,
> then there is no need to invert the sign. Similarly,
> if it returns -EPROBE_DEFER, no sign inversion is needed either
> 
> In the probe function (either bus->probe() or drv->probe()),
> there is no return value of EPROBE_DEFER.
> 
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
>  drivers/base/dd.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 83d352394fdf..cbf7fe6aa8e0 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -664,11 +664,6 @@ static int really_probe(struct device *dev, struct device_driver *drv)
>  		if (link_ret == -EAGAIN)
>  			ret = -EPROBE_DEFER;
>  
> -		/*
> -		 * Return probe errors as positive values so that the callers
> -		 * can distinguish them from other errors.
> -		 */
> -		ret = -ret;
>  		goto probe_failed;
>  	}
>  
> -- 
> 2.17.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot