* [PATCH] cpufreq: sti: fix build warning
@ 2024-07-08 17:14 Raphael Gallais-Pou
2024-07-09 3:14 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Raphael Gallais-Pou @ 2024-07-08 17:14 UTC (permalink / raw)
To: Patrice Chotard, 'Rafael J . Wysocki', Viresh Kumar
Cc: linux-arm-kernel, linux-pm, linux-kernel
Building this driver yields the following:
.../drivers/cpufreq/sti-cpufreq.c:215:50: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=]
215 | snprintf(name, MAX_PCODE_NAME_LEN, pcode%d, pcode);
| ^~
.../drivers/cpufreq/sti-cpufreq.c:215:44: note: directive argument in the range [0, 2147483647]
215 | snprintf(name, MAX_PCODE_NAME_LEN, pcode%d, pcode);
| ^~~~~~~~~
.../drivers/cpufreq/sti-cpufreq.c:215:9: note: ‘snprintf’ output between 7 and 16 bytes into a destination of size 7
215 | snprintf(name, MAX_PCODE_NAME_LEN, pcode%d, pcode);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix the buffer size to avoid the warning at build time.
Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
---
drivers/cpufreq/sti-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c
index 1ffa23dd8907..8e2e703c3865 100644
--- a/drivers/cpufreq/sti-cpufreq.c
+++ b/drivers/cpufreq/sti-cpufreq.c
@@ -18,7 +18,7 @@
#include <linux/regmap.h>
#define VERSION_ELEMENTS 3
-#define MAX_PCODE_NAME_LEN 7
+#define MAX_PCODE_NAME_LEN 16
#define VERSION_SHIFT 28
#define HW_INFO_INDEX 1
--
2.45.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] cpufreq: sti: fix build warning
2024-07-08 17:14 [PATCH] cpufreq: sti: fix build warning Raphael Gallais-Pou
@ 2024-07-09 3:14 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2024-07-09 3:14 UTC (permalink / raw)
To: Raphael Gallais-Pou
Cc: Patrice Chotard, 'Rafael J . Wysocki',
linux-arm-kernel, linux-pm, linux-kernel
On 08-07-24, 19:14, Raphael Gallais-Pou wrote:
> Building this driver yields the following:
>
> .../drivers/cpufreq/sti-cpufreq.c:215:50: warning: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=]
> 215 | snprintf(name, MAX_PCODE_NAME_LEN, pcode%d, pcode);
> | ^~
> .../drivers/cpufreq/sti-cpufreq.c:215:44: note: directive argument in the range [0, 2147483647]
> 215 | snprintf(name, MAX_PCODE_NAME_LEN, pcode%d, pcode);
> | ^~~~~~~~~
> .../drivers/cpufreq/sti-cpufreq.c:215:9: note: ‘snprintf’ output between 7 and 16 bytes into a destination of size 7
> 215 | snprintf(name, MAX_PCODE_NAME_LEN, pcode%d, pcode);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fix the buffer size to avoid the warning at build time.
>
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
> drivers/cpufreq/sti-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-09 3:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-08 17:14 [PATCH] cpufreq: sti: fix build warning Raphael Gallais-Pou
2024-07-09 3:14 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®